Uh oh!
There was an error while loading. Please reload this page.
Use more accurate spans for "unused delimiter" lint - #88779
Merged
Conversation
rust-highfive
commented
Sep 9, 2021
Contributor
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
davidtwco
approved these changes
Sep 9, 2021
davidtwco
left a comment
Member
There was a problem hiding this comment.
LGTM, code is much clearer now and better diagnostics! r=me once CI passes.
estebank
commented
Sep 9, 2021
ContributorAuthor
@bors r=davidtwco |
bors
commented
Sep 9, 2021
Collaborator
📌 Commit dc02b51 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 11, 2021
Use more accurate spans for "unused delimiter" lint
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 11, 2021
Use more accurate spans for "unused delimiter" lint
This was referenced Sep 11, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2021
…ingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#87904 (Reword description of automatic impls of `Unsize`.) - rust-lang#88147 (Fix non-capturing closure return type coercion) - rust-lang#88209 (Improve error message when _ is used for in/inout asm operands) - rust-lang#88668 (Change more x64 size checks to not apply to x32.) - rust-lang#88733 (Fix ICE for functions with more than 65535 arguments) - rust-lang#88757 (Suggest wapping expr in parentheses on invalid unary negation) - rust-lang#88779 (Use more accurate spans for "unused delimiter" lint) - rust-lang#88830 (Add help for E0463) - rust-lang#88849 (don't clone types that are Copy (clippy::clone_on_copy)) - rust-lang#88850 (don't convert types into identical types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.