Implement write() method for Box<MaybeUninit<T>> by Kixunil · Pull Request #88906 · rust-lang/rust

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

Kixunil · 2021-09-13T13:52:01Z

This adds method similar to MaybeUninit::write main difference being
it returns owned Box. This can be used to elide copy from stack
safely, however it's not currently tested that the optimization actually
occurs.

Analogous methods are not provided for Rc and Arc as those need to
handle the possibility of sharing. Some version of them may be added in
the future.

This was discussed in #63291 which this change extends.

rust-highfive · 2021-09-13T13:52:05Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

the8472 · 2021-09-13T16:36:42Z

There's a pending RFC that proposes another approach which would probably make this one redundant.

rust-lang/rfcs#2884

Kixunil · 2021-09-14T10:39:54Z

@the8472 thanks for heads up! It could be argued it also makes #6321 redundant (although that one can be useful in FFI but then why not add this one for completeness?)

JohnCSimon · 2021-10-24T23:18:15Z

Ping from triage:
@Kixunil What is the status of this PR? Are you still interested in moving forward?

Kixunil · 2021-10-25T09:35:03Z

Sure! This is waiting on reviewer. I believe this change is simple and obvious.

dtolnay

I believe this change is simple and obvious.

To point out why this change isn't simple and obvious: this is a breaking change. It can make previously working code fail to compile, or keep compiling but do the wrong thing, or silently introduce UB into existing correct code.

Here is an example of an ordinary idiomatic use of MaybeUninit which would no longer work:

structThing{buf:Box<MaybeUninit<[u8;N]>>,}implThing{fnmethod(&mutself){let _arr = self.buf.write([0;N]);}}

Kixunil · 2021-11-26T22:27:19Z

Ah, I see, good point. I think changing it to fn write(this: Self) would fix it, right? Will try to do it when I have time (shouldn't be more than couple of days).

bors · 2021-11-28T16:26:49Z

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-02T16:14:49Z

Fixed and rebased. Also noticed that wording in the example looked like a promise of optimization which is not actually guaranteed, so I reworded it accordingly.

This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

dtolnay

Thanks!

dtolnay · 2021-12-03T03:45:14Z

@bors r+

bors · 2021-12-03T03:45:16Z

📌 Commit 41e21aa has been approved by dtolnay

…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-12-03T10:25:35Z

☔ The latest upstream changes (presumably #91486) made this pull request unmergeable. Please resolve the merge conflicts.

Kixunil · 2021-12-03T10:48:02Z

I'm confused by this - it conflicted with an unmerged PR? Is this some fluke or am I actually supposed to do something (what?) about it?

emilyalbini · 2021-12-03T11:43:25Z

This has been merged into master by bors (in #91486), but GitHub didn't detect it for whatever reason. Closing.

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

rust-highfive assigned dtolnay Sep 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 005cd4b to d0c2ccfCompare September 13, 2021 13:58

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from d0c2ccf to 322b67dCompare September 13, 2021 14:06

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 322b67d to f747ae4Compare September 13, 2021 14:42

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 21, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021

dtolnay reviewed Nov 26, 2021
View reviewed changes

dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

Kixunil force-pushed the box-maybe-uninit-write branch 2 times, most recently from 9bdca22 to 928a0b0Compare December 2, 2021 16:13

This comment has been minimized.
Sign in to view

Kixunil force-pushed the box-maybe-uninit-write branch from 928a0b0 to 41e21aaCompare December 2, 2021 16:18

Kixunil requested a review from dtolnay December 2, 2021 17:54

dtolnay approved these changes Dec 3, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 11 pull requests #91485
Closed

matthiaskrgr mentioned this pull request Dec 3, 2021
Rollup of 10 pull requests #91486
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2021

emilyalbini closed this Dec 3, 2021

Kixunil deleted the box-maybe-uninit-write branch December 3, 2021 11:48

dtolnay mentioned this pull request Feb 18, 2025
Tracking Issue for box_uninit_write#129397
Closed
3 tasks

Uh oh!

Uh oh!

Conversation

Kixunil commented Sep 13, 2021

Uh oh!

rust-highfive commented Sep 13, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

the8472 commented Sep 13, 2021

Uh oh!

Kixunil commented Sep 14, 2021

Uh oh!

JohnCSimon commented Oct 24, 2021

Uh oh!

Kixunil commented Oct 25, 2021

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

Kixunil commented Nov 26, 2021

Uh oh!

bors commented Nov 28, 2021

Uh oh!

Kixunil commented Dec 2, 2021

Uh oh!

This comment has been minimized.

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Dec 3, 2021

Uh oh!

bors commented Dec 3, 2021

Uh oh!

bors commented Dec 3, 2021

Uh oh!

Kixunil commented Dec 3, 2021

Uh oh!

emilyalbini commented Dec 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

Kixunil commented Sep 13, 2021

Uh oh!

rust-highfive commented Sep 13, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

the8472 commented Sep 13, 2021

Uh oh!

Kixunil commented Sep 14, 2021

Uh oh!

JohnCSimon commented Oct 24, 2021

Uh oh!

Kixunil commented Oct 25, 2021

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

Kixunil commented Nov 26, 2021

Uh oh!

bors commented Nov 28, 2021

Uh oh!

Kixunil commented Dec 2, 2021

Uh oh!

This comment has been minimized.

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!