Skip to content

Expose the std_detect env_override feature - #88973

Merged
bors merged 1 commit into
rust-lang:masterfrom
lu-zero:std_detect-env_override
Sep 26, 2021
Merged

Expose the std_detect env_override feature#88973
bors merged 1 commit into
rust-lang:masterfrom
lu-zero:std_detect-env_override

Conversation

@lu-zero

Copy link
Copy Markdown
Contributor

No description provided.

@lu-zero

Copy link
Copy Markdown
ContributorAuthor

r? @bjorn3

@bjorn3

Copy link
Copy Markdown
Member

r? @Amanieu Whether or not to expose this feature is not a decision I think I should make.

@rust-highfiverust-highfive assigned Amanieu and unassigned bjorn3Sep 25, 2021
@Amanieu

Copy link
Copy Markdown
Member

You need to add it to the test crate as well for -Z build-std-features to work.

Also keep in mind that features on standard library crates are considered unstable and may change until -Z build-std-features is stabilized.

@lu-zero
lu-zeroforce-pushed the std_detect-env_override branch from f23f59a to 160b939CompareSeptember 25, 2021 18:30
@lu-zero

Copy link
Copy Markdown
ContributorAuthor

Thank you for spotting it! It is good to consider it unstable.

@Amanieu

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 26, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 160b939 has been approved by Amanieu

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 26, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2021
…arth
Rollup of 7 pull requests
Successful merges:
- rust-lang#88895 (rustdoc: Cleanup `clean` part 2)
- rust-lang#88973 (Expose the std_detect env_override feature)
- rust-lang#89010 (Add some intra doc links)
- rust-lang#89198 (rustdoc: Don't show hidden trait methods)
- rust-lang#89216 (Consistent big O notation)
- rust-lang#89224 (Change the order of imports suggestions)
- rust-lang#89256 (Fix typo in release notes)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f9d4eb0 into rust-lang:masterSep 26, 2021
@rustbotrustbot added this to the 1.57.0 milestone Sep 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lu-zero@bjorn3@Amanieu@bors@rustbot