Uh oh!
There was an error while loading. Please reload this page.
Disable RemoveZsts in generators to avoid query cycles - #88979
Merged
Conversation
Querying layout of a generator requires its optimized MIR. Thus computing layout during MIR optimization of a generator might create a query cycle. Disable RemoveZsts in generators to avoid the issue (similar approach is used in ConstProp transform already).
rust-highfive
commented
Sep 15, 2021
Contributor
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Sep 15, 2021
Member
beta-nominating -- needed to fix #88972, which is a beta regression |
oli-obk
commented
Sep 15, 2021
Contributor
bors
commented
Sep 15, 2021
Collaborator
📌 Commit c39d759 has been approved by |
bors
commented
Sep 15, 2021
Collaborator
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
jackh726
commented
Sep 15, 2021
Member
r? @oli-obk didn't seem to get picked up before |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Sep 16, 2021
…s, r=oli-obk Disable RemoveZsts in generators to avoid query cycles Querying layout of a generator requires its optimized MIR. Thus computing layout during MIR optimization of a generator might create a query cycle. Disable RemoveZsts in generators to avoid the issue (similar approach is used in ConstProp transform already). Fixesrust-lang#88972.
wesleywiser
commented
Sep 16, 2021
Member
Bumping priority since this fixes a stable-to-beta regression. @bors p=1 |
bors
commented
Sep 16, 2021
Collaborator
bors
commented
Sep 16, 2021
Collaborator
☀️ Test successful - checks-actions |
apiraino
commented
Sep 23, 2021
Contributor
ehuss pushed a commit
to ehuss/rust
that referenced
this pull request
Oct 4, 2021
… r=oli-obk Disable RemoveZsts in generators to avoid query cycles Querying layout of a generator requires its optimized MIR. Thus computing layout during MIR optimization of a generator might create a query cycle. Disable RemoveZsts in generators to avoid the issue (similar approach is used in ConstProp transform already). Fixesrust-lang#88972.
Merged
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2021
[beta] Beta rollup * Fix WinUWP std compilation errors due to I/O safety rust-lang#88587 * Disable RemoveZsts in generators to avoid query cycles rust-lang#88979 * Disable the evaluation cache when in intercrate mode rust-lang#88994 * Fix linting when trailing macro expands to a trailing semi rust-lang#88996 * Don't use projection cache or candidate cache in intercrate mode rust-lang#89125 * 2229: Mark insignificant dtor in stdlib rust-lang#89144 * Temporarily rename int_roundings functions to avoid conflicts rust-lang#89184 * [rfc 2229] Drop fully captured upvars in the same order as the regular drop code rust-lang#89208 * Use the correct edition for syntax highlighting doctests rust-lang#89277 * Don't normalize opaque types with escaping late-bound regions rust-lang#89285 * Update Let's Encrypt ROOT CA certificate in dist-(i686|x86_64)-linux docker images rust-lang#89486 Cargo update: * - [beta] 1.56 backports (rust-lang/cargo#9958) * - [beta] Revert "When a dependency does not have a version, git or path… (rust-lang/cargo#9912) * - [beta] Fix rustc --profile=dev unstable check. (rust-lang/cargo#9901)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Querying layout of a generator requires its optimized MIR. Thus
computing layout during MIR optimization of a generator might create a
query cycle. Disable RemoveZsts in generators to avoid the issue
(similar approach is used in ConstProp transform already).
Fixes#88972.