Uh oh!
There was an error while loading. Please reload this page.
Reuse existing shared Lrc for MatchImpl parent - #89000
Conversation
This is hopefully a small performance win for the hot path.
rust-highfive
commented
Sep 16, 2021
(rust-highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Sep 16, 2021
@bors try @rust-timer queue |
rust-timer
commented
Sep 16, 2021
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
bors
commented
Sep 16, 2021
⌛ Trying commit 905beab with merge 7673a3aaa9e105ce44a072adc092435bee541800... |
bors
commented
Sep 16, 2021
☀️ Try build successful - checks-actions |
rust-timer
commented
Sep 16, 2021
Queued 7673a3aaa9e105ce44a072adc092435bee541800 with parent 4aed1ab, future comparison URL. |
rust-timer
commented
Sep 16, 2021
Finished benchmarking commit (7673a3aaa9e105ce44a072adc092435bee541800): comparison url. Summary: This change led to very small relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
petrochenkov
commented
Sep 16, 2021
@bors r+ |
bors
commented
Sep 16, 2021
📌 Commit 905beab has been approved by |
bors
commented
Sep 18, 2021
bors
commented
Sep 18, 2021
☀️ Test successful - checks-actions |
rust-timer
commented
Sep 19, 2021
Finished benchmarking commit (aa8f2d4): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This is a small performance win for the hot path, which helps to address this regression: #87244 (comment).