Uh oh!
There was an error while loading. Please reload this page.
Try to reuse buffers in String::extend - #89169
Closed
Lucretiel wants to merge 0 commit into
Closed
Conversation
rust-highfive
commented
Sep 22, 2021
Contributor
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joshtriplett
commented
Oct 4, 2021
Member
Looks reasonable to me. r=me once CI passes and once a perf run confirms that this is either neutral or an improvement. |
Lucretiel
commented
Oct 5, 2021
ContributorAuthor
CI is failing on |
Mark-Simulacrum
commented
Nov 12, 2021
Member
It's not clear to me why it's failing either. It may help to rebase on latest master so we can rerun CI, at least? It does seem likely to be related to cfg(test) somehow, but I'm not sure how. It may be that we just need to cfg out this impl in cfg(test) or something like that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the logic around buffer reuse in
FromIterator<String> for StringintoExtendand a few otherFromIteratorimplementations. Basically, in cases where we're extending from allocated types (String,Cow<str>,Box<str>), we check ifselfis empty and, if so, just take the incoming value by move rather than copying the data.Follow up to #56548.