Run no_core rustdoc tests only on Linux

[hkratz]

I don't think this is really worth investigating further so I just disabled them.

They currently fail like this:

error: linking with `cc` failed: exit status: 1
|
= note: "cc" "-Wl,-exported_symbols_list,/var/folders/pg/gjhzdz7n361f0pv665d0723w0000gn/T/rustcPUsMpx/list" "-arch" "arm64" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary/my-core.my_core.9f3c60de-cgu.0.rcgu.o" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary/my-core.50fu2g9urkmisdsg.rcgu.o" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/native/rust-test-helpers" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/stage1/lib/rustlib/aarch64-apple-darwin/lib" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/stage1/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary/libmy_core.dylib" "-Wl,-dead_strip" "-dynamiclib" "-Wl,-dylib" "-Wl,-install_name" "-Wl,@rpath/libmy_core.dylib" "-nodefaultlibs"
= note: ld: dynamic main executables must link with libSystem.dylib for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

r? @jyn514

[jyn514]

I don't really feel like playing wack-a-mole with these tests. Can you just change it to only-linux or something instead?

[hkratz]

I don't really feel like playing wack-a-mole with these tests. Can you just change it to only-linux or something instead?

Done.

[jyn514]

(this is waiting on me running this locally on a Linux host and making sure it actually runs rather than being ignored - if you want to speed it up and have a Linux machine you could do that yourself, otherwise I'll try to get to it by this weekend.)

[hkratz]

(this is waiting on me running this locally on a Linux host and making sure it actually runs rather than being ignored - if you want to speed it up and have a Linux machine you could do that yourself, otherwise I'll try to get to it by this weekend.)

I can confirm that the test now runs on Linux and is ignored on Macos.

Linux:

$ ./x.py test --force-rerun src/test/rustdoc/cross-crate-primitive-doc.rs
[...]
running 1 test
.
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 469 filtered out; finished in 0.11s

Macos:

$ ./x.py test --force-rerun src/test/rustdoc/cross-crate-primitive-doc.rs
[...]
running 1 test
i
test result: ok. 0 passed; 0 failed; 1 ignored; 0 measured; 469 filtered out; finished in 0.00s

[jyn514]

@bors r+ rollup

Thanks!

[bors]

📌 Commit da6f01d has been approved by jyn514