Skip to content

Enable "generate-link-to-definition" option on rust tools docs as well - #89217

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:generate-link-to-def-rust-tools
Sep 25, 2021
Merged

Enable "generate-link-to-definition" option on rust tools docs as well#89217
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:generate-link-to-def-rust-tools

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Sep 24, 2021

Copy link
Copy Markdown
Member

Just realized that we enable the option for the compiler crates, but we don't have it for rustdoc and the other tools documentation...

Part of #89095.

cc @rust-lang/rustdoc
r? @Mark-Simulacrum

@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 24, 2021
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2021
@jyn514

Copy link
Copy Markdown
Member

@GuillaumeGomez why did you cc the whole team?

@bors r+ rollup

@bors

bors commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 9fa59e1 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2021
@jyn514jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 24, 2021
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

To keep everyone up-to-date. I think it's an important change after all.

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 24, 2021
…-rust-tools, r=jyn514
Enable "generate-link-to-definition" option on rust tools docs as well
Just realized that we enable the option for the compiler crates, but we don't have it for rustdoc and the other tools documentation...
Part of rust-lang#89095.
cc `@rust-lang/rustdoc`
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2021
…ingjubilee
Rollup of 8 pull requests
Successful merges:
- rust-lang#88893 (Add 1.56.0 release notes)
- rust-lang#89001 (Be explicit about using Binder::dummy)
- rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm )
- rust-lang#89104 (Simplify scoped_thread)
- rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code)
- rust-lang#89210 (Add missing time complexities to linked_list.rs)
- rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well)
- rust-lang#89221 (Give better error for `macro_rules! name!`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0cd9dd3 into rust-lang:masterSep 25, 2021
@rustbotrustbot added this to the 1.57.0 milestone Sep 25, 2021
@GuillaumeGomez
GuillaumeGomez deleted the generate-link-to-def-rust-tools branch September 25, 2021 09:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@jyn514@bors@Mark-Simulacrum@rust-highfive@rustbot