resolve: Cache module loading for all foreign modules

[petrochenkov]

It was previously cached for modules loaded from fn get_module, but not for modules loaded from fn build_reduced_graph_for_external_crate_res.
This also makes all foreign modules use their real parent, span and expansion instead of possibly a parent/span/expansion of their reexport.
Modules are also often compared using referential equality (ptr::eq), this change makes such comparisons correct in all cases.

An ICE happening on attempt to decode expansions for foreign enums and traits is avoided.

Also local enums and traits are now added to the module map.

Follow up to #88872.
r? @cjgillot

[petrochenkov]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 3540ab1b57946e30e9819a2ae728097f570ffa98 with merge 46cc8acbde83e77d3533062bd987267715fc05eb...

[bors]

☀️ Try build successful - checks-actions
Build commit: 46cc8acbde83e77d3533062bd987267715fc05eb (46cc8acbde83e77d3533062bd987267715fc05eb)

[rust-timer]

Queued 46cc8acbde83e77d3533062bd987267715fc05eb with parent 7342213, future comparison URL.

[rust-timer]

Finished benchmarking commit (46cc8acbde83e77d3533062bd987267715fc05eb): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

• Large regression in instruction counts (up to 2.0% on incr-unchanged builds of webrender-wrench)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[petrochenkov]

This also makes all foreign modules use their real parent, span and expansion instead of possibly a parent/span/expansion of their reexport.

This is a correctness fix (for macros 2.0, I'll try to add a test case, e.g. with a macro 2.0 using super), but it does require decoding more in some cases.

The largest regression (webrender-wrench-check) is due to a larger number of the type_of query invocations, so it's either spurious, or is a result of some larger number of incremental invalidations due to the correctness fix above.
Other regressions are under 0.7%.

[petrochenkov]

Updated.

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit bfc2b31a4ee5890829adfc7c260ee39cbd0c749f with merge 6e3cd17ee9b9b29b92ebe126cd606f7adb0e7307...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6e3cd17ee9b9b29b92ebe126cd606f7adb0e7307 (6e3cd17ee9b9b29b92ebe126cd606f7adb0e7307)

[rust-timer]

Queued 6e3cd17ee9b9b29b92ebe126cd606f7adb0e7307 with parent ac8dd1b, future comparison URL.

[bors]

📌 Commit a0d70bd224f0510cea6b0be6c2d0d276d17af5d9 has been approved by cjgillot

[bors]

⌛ Testing commit a0d70bd224f0510cea6b0be6c2d0d276d17af5d9 with merge 59f8b8d94bffcbd19f5c39f823c9f970f823bfac...

[bors]

💔 Test failed - checks-actions

[petrochenkov]

@bors r=cjgillot

[bors]

📌 Commit d7d0765 has been approved by cjgillot

[bors]

⌛ Testing commit d7d0765 with merge d14731c...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing d14731c to master...

[rust-timer]

Finished benchmarking commit (d14731c): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

[Mark-Simulacrum]

This corrects behaviour for macros 2.0 and avoids an ICE, so a .7% regression seems acceptable.

@rustbot label +perf-regression-triaged