Skip to content

Don't lose binders when printing trait bound suggestion - #89345

Merged
bors merged 2 commits into
rust-lang:masterfrom
jackh726:89333
Oct 3, 2021
Merged

Don't lose binders when printing trait bound suggestion#89345
bors merged 2 commits into
rust-lang:masterfrom
jackh726:89333

Conversation

@jackh726

@jackh726jackh726 commented Sep 29, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#89333

@rust-highfive

rust-highfive commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2021
@cuviper

This comment has been minimized.

Sign in to view
@jackh726

jackh726 commented Sep 29, 2021

Copy link
Copy Markdown
MemberAuthor

Whoops, thanks. Fixed.

@estebank

estebank commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

r? @estebank
@bors r+

@bors

bors commented Sep 29, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 8cf6c42 has been approved by estebank

@rust-highfiverust-highfive assigned estebank and unassigned nagisaSep 29, 2021
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2021
@jackh726

jackh726 commented Sep 30, 2021

Copy link
Copy Markdown
MemberAuthor

@bors rollup

ehuss added a commit to ehuss/rust that referenced this pull request Sep 30, 2021
@ehuss
Rollup merge ofrust-lang#89345- jackh726:89333, r=estebank
690eddf
Don't lose binders when printing trait bound suggestion
Fixesrust-lang#89333
@ehussehuss mentioned this pull request Sep 30, 2021
Closed
@jyn514

jyn514 commented Sep 30, 2021

Copy link
Copy Markdown
Member

@bors r-

Failed in rollup: #89399 (comment)

(I think this is the right PR, not 100% sure)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2021
@jackh726

jackh726 commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

@bors rollup=iffy

@estebank I've updated the test to use a local trait, rather than Default, since I guess there are fewer impls in wasm-32.

@jackh726jackh726 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2021
@jackh726

jackh726 commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

Actually, given that this is only a slight change to the test, I'm going to just @bors r=estebank

@bors

bors commented Oct 1, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 4bd1751 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2021
@bors

bors commented Oct 2, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4bd1751 with merge 2801a77...

@bors

bors commented Oct 3, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2801a77 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 3, 2021
@bors
bors merged commit 2801a77 into rust-lang:masterOct 3, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 3, 2021
@jackh726
jackh726 deleted the 89333 branch October 3, 2021 01:05
@rust-timer

rust-timer commented Oct 3, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2801a77): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@jackh726
jackh726 restored the 89333 branch March 12, 2022 18:30
@jackh726
jackh726 deleted the 89333 branch March 12, 2022 18:36
@jackh726
jackh726 restored the 89333 branch March 12, 2022 18:42
@jackh726
jackh726 deleted the 89333 branch March 12, 2022 18:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

ICE in nightly with assertion failed: !value.has_escaping_bound_vars()

9 participants

@jackh726@rust-highfive@cuviper@estebank@bors@jyn514@rust-timer@nagisa@rustbot