Point at overlapping impls when type annotations are needed by estebank · Pull Request #89427 · rust-lang/rust

estebank · 2021-10-01T13:07:04Z

Address #89254.

rust-highfive · 2021-10-01T13:07:07Z

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

estebank · 2021-10-01T13:07:42Z

@bors try @rust-timer queue

rust-timer · 2021-10-01T13:07:43Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-10-01T13:07:58Z

⌛ Trying commit ce9b15e5fe151c352daef9a952be011112cfe881 with merge 96d6dfc04cc7ea021ad7b494bfbb0041be4e083c...

estebank · 2021-10-01T13:24:03Z

@bors try @rust-timer queue

rust-timer · 2021-10-01T13:24:04Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-10-01T13:24:10Z

⌛ Trying commit a6b97196c4c1ff8acf22d3b2f27848de9c325a4e with merge 19148e7dc43cf0314f81a60dd944631ca719942c...

petrochenkov · 2021-10-01T14:00:45Z

r? @rust-lang/wg-traits

petrochenkov · 2021-10-01T14:03:49Z

It didn't work, selecting a random active member.
r? @spastorino

bors · 2021-10-01T14:48:27Z

☀️ Try build successful - checks-actions
Build commit: 19148e7dc43cf0314f81a60dd944631ca719942c (19148e7dc43cf0314f81a60dd944631ca719942c)

rust-timer · 2021-10-01T14:48:29Z

Queued 19148e7dc43cf0314f81a60dd944631ca719942c with parent 69eb996, future comparison URL.

rust-timer · 2021-10-01T19:18:22Z

Finished benchmarking commit (19148e7dc43cf0314f81a60dd944631ca719942c): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

Moderate improvement in instruction counts (up to -0.7% on full builds of diesel)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

jackh726 · 2021-10-01T20:12:52Z

It didn't work, selecting a random active member.

Yeah, should be "rust-lang/traits", but it might be prudent to make "wg-traits" an alias for that.

nikomatsakis

this looks good to me! I didn't give it a detailed read, though, so maybe better for @spastorino or others to look a touch more closely at the code.

bors · 2021-10-08T14:38:02Z

☔ The latest upstream changes (presumably #89576) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2021-10-14T10:13:21Z

@spastorino ping

estebank · 2021-10-24T14:43:30Z

Here we should try and figure out that T is a type we can infer, while U is not, for a more targeted suggestion.

estebank · 2021-10-24T16:42:23Z

@bors r=jackh726

bors · 2021-10-24T16:42:24Z

📌 Commit 8c2bed87beb9558feaa310a2dc8d93f67edf2705 has been approved by jackh726

bors · 2021-10-24T17:07:51Z

⌛ Testing commit 8c2bed87beb9558feaa310a2dc8d93f67edf2705 with merge 3296562b6104d82890a18c6ce7073df9032be3f9...

bors · 2021-10-24T17:51:03Z

💔 Test failed - checks-actions

estebank · 2021-10-24T20:29:12Z

@bors r=jackh726

bors · 2021-10-24T20:29:13Z

📌 Commit 881a50c has been approved by jackh726

bors · 2021-10-24T22:26:44Z

⌛ Testing commit 881a50c with merge 41d8c94...

bors · 2021-10-25T01:10:46Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 41d8c94 to master...

rust-timer · 2021-10-25T02:42:23Z

Finished benchmarking commit (41d8c94): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rust-highfive assigned petrochenkov Oct 1, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 1, 2021

This comment has been minimized.
Sign in to view

estebank force-pushed the collect-overlapping-impls branch from ce9b15e to a6b9719Compare October 1, 2021 13:23

rust-highfive assigned spastorino and unassigned petrochenkov Oct 1, 2021

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 1, 2021

estebank changed the title ~~[wip] Point at overlapping impls when type annotations are needed~~Point at overlapping impls when type annotations are neededOct 4, 2021

estebank force-pushed the collect-overlapping-impls branch from 7c1f014 to 4a85552Compare October 4, 2021 12:17

nikomatsakis reviewed Oct 4, 2021
View reviewed changes

estebank force-pushed the collect-overlapping-impls branch from 4a85552 to cb807e7Compare October 13, 2021 14:50

jackh726 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 23, 2021

estebank commented Oct 24, 2021
View reviewed changes

estebank force-pushed the collect-overlapping-impls branch from cb807e7 to 8c2bed8Compare October 24, 2021 16:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2021

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2021

estebank added 2 commits October 24, 2021 18:33

Point at overlapping impls when type annotations are needed
ef212e7

Always sort suggestions before emitting them
881a50c

estebank force-pushed the collect-overlapping-impls branch from 8c2bed8 to 881a50cCompare October 24, 2021 20:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2021

bors merged commit 41d8c94 into rust-lang:masterOct 25, 2021

rustbot added this to the 1.58.0 milestone Oct 25, 2021

spastorino mentioned this pull request Oct 25, 2021
Fix negative traits coherence checks compile error message for type aliases #90259
Open

JakobDegen mentioned this pull request Oct 27, 2021
Add hint for people missing TryFrom, TryInto, FromIterator import pre-2021 #90288
Merged

SNCPlay42 mentioned this pull request Jan 29, 2022
Error output regression: spurious integer inference error that only occurs if another error occurs #93450
Closed

estebank deleted the collect-overlapping-impls branch November 9, 2023 05:14

Uh oh!

Uh oh!

Conversation

estebank commented Oct 1, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Oct 1, 2021

Uh oh!

estebank commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

This comment has been minimized.

estebank commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

petrochenkov commented Oct 1, 2021

Uh oh!

petrochenkov commented Oct 1, 2021

Uh oh!

This comment has been minimized.

bors commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

jackh726 commented Oct 1, 2021

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

bors commented Oct 8, 2021

Uh oh!

estebank commented Oct 14, 2021

Uh oh!

estebankOct 24, 2021

Choose a reason for hiding this comment

Uh oh!

estebank commented Oct 24, 2021

Uh oh!

bors commented Oct 24, 2021

Uh oh!

bors commented Oct 24, 2021

Uh oh!

This comment has been minimized.

bors commented Oct 24, 2021

Uh oh!

estebank commented Oct 24, 2021

Uh oh!

bors commented Oct 24, 2021

Uh oh!

bors commented Oct 24, 2021

Uh oh!

bors commented Oct 25, 2021

Uh oh!

rust-timer commented Oct 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

estebank commented Oct 1, 2021•
edited
Loading