Skip to content

Add deref_into_dyn_supertrait lint. - #89461

Merged
bors merged 1 commit into
rust-lang:masterfrom
crlf0710:dyn_upcasting_lint
Oct 7, 2021
Merged

Add deref_into_dyn_supertrait lint.#89461
bors merged 1 commit into
rust-lang:masterfrom
crlf0710:dyn_upcasting_lint

Conversation

@crlf0710

Copy link
Copy Markdown
Member

Initial implementation of #89460. Resolves#89190.
Maybe also worth a beta backport if necessary.

r? @nikomatsakis

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2021
@rust-log-analyzer

This comment has been minimized.

Comment threadcompiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated
@crlf0710crlf0710 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. F-trait_upcasting `#![feature(trait_upcasting)]` labels Oct 3, 2021
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 250d126 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2021
…laumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#89298 (Issue 89193 - Fix ICE when using `usize` and `isize` with SIMD gathers )
- rust-lang#89461 (Add `deref_into_dyn_supertrait` lint.)
- rust-lang#89477 (Move items related to computing diffs to a separate file)
- rust-lang#89559 (RustWrapper: adapt for LLVM API change)
- rust-lang#89585 (Emit item no type error even if type inference fails)
- rust-lang#89596 (Make cfg imply doc(cfg))
- rust-lang#89615 (Add InferCtxt::with_opaque_type_inference to get_body_with_borrowck_facts)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ab276b8 into rust-lang:masterOct 7, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 7, 2021
@crlf0710
crlf0710 deleted the dyn_upcasting_lint branch October 8, 2021 08:44
@pnkfelixpnkfelix added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 16, 2021
@pnkfelix

Copy link
Copy Markdown
Contributor

(This is already in the 1.57-beta, according to discussion on #89190. So I'll just stable-nominate it.)

@pnkfelixpnkfelix added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Nov 16, 2021
@apirainoapiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021
@apiraino

Copy link
Copy Markdown
Contributor

Stable backport declined as per compiler team on Zulip

@rustbot label -stable-nominated

@rustbotrustbot removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Nov 18, 2021
Tamschi added a commit to Tamschi/fruit-salad that referenced this pull request Nov 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.F-trait_upcasting`#![feature(trait_upcasting)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trait upcasting shadows (trait object) deref coercion

9 participants

@crlf0710@rust-log-analyzer@nikomatsakis@bors@pnkfelix@apiraino@notriddle@rust-highfive@rustbot