Uh oh!
There was an error while loading. Please reload this page.
Fixed numerus of error message - #89478
Merged
Merged
Conversation
rust-highfive
commented
Oct 2, 2021
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
klensy
reviewed
Oct 2, 2021
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
jyn514
commented
Oct 3, 2021
Member
@bors r+ |
bors
commented
Oct 3, 2021
Collaborator
📌 Commit d20e7cec020e6cc008be808f9b5c958e1b943018 has been approved by |
klensy
commented
Oct 3, 2021
Contributor
4 commits, squash maybe? |
Member
@bors r- Yes, let's squash the commits. |
Fixed numerus of error message Removed superfluous argument Using pluralize!() instead of code duplication Adjusted a test
jyn514
commented
Oct 3, 2021
Member
@bors r+ rollup |
bors
commented
Oct 3, 2021
Collaborator
📌 Commit d6a7e74 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 5, 2021
Fixed numerus of error message
When there are redundant trait requirements and these are hidden, a message is generated by the following code snippet:
`format!("{} redundant requirements hidden", count)`
But if there is only a single hidden requirement, it will still print this message in plural instead of singular.Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 5, 2021
Fixed numerus of error message
When there are redundant trait requirements and these are hidden, a message is generated by the following code snippet:
`format!("{} redundant requirements hidden", count)`
But if there is only a single hidden requirement, it will still print this message in plural instead of singular.Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 5, 2021
Fixed numerus of error message
When there are redundant trait requirements and these are hidden, a message is generated by the following code snippet:
`format!("{} redundant requirements hidden", count)`
But if there is only a single hidden requirement, it will still print this message in plural instead of singular.bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2021
…ingjubilee Rollup of 15 pull requests Successful merges: - rust-lang#87993 (Stabilize try_reserve) - rust-lang#88090 (Perform type inference in range pattern) - rust-lang#88780 (Added abs_diff for integer types.) - rust-lang#89270 (path.push() should work as expected on windows verbatim paths) - rust-lang#89413 (Correctly handle supertraits for min_specialization) - rust-lang#89456 (Update to the final LLVM 13.0.0 release) - rust-lang#89466 (Fix bug with query modifier parsing) - rust-lang#89473 (Fix extra `non_snake_case` warning for shorthand field bindings) - rust-lang#89474 (rustdoc: Improve doctest pass's name and module's name) - rust-lang#89478 (Fixed numerus of error message) - rust-lang#89480 (Add test for issue 89118.) - rust-lang#89487 (Try to recover from a `=>` -> `=` or `->` typo in a match arm) - rust-lang#89494 (Deny `where` clauses on `auto` traits) - rust-lang#89511 (:arrow_up: rust-analyzer) - rust-lang#89536 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are redundant trait requirements and these are hidden, a message is generated by the following code snippet:
format!("{} redundant requirements hidden", count)But if there is only a single hidden requirement, it will still print this message in plural instead of singular.