Move some tests to more reasonable directories - 8 by c410-f3r · Pull Request #89488 · rust-lang/rust

c410-f3r · 2021-10-03T12:59:37Z

petrochenkov · 2021-10-10T21:10:40Z

The move of the whole in-band-lifetimes subdirectory to into impl-trait looks like an accidental mistake.

issue-59029-1.rs -> traits/alias
bastion-of-the-turbofish.rs -> parser
issue-13902.rs -> consts
issue-23968-const-not-overflow.rs -> consts
raw-fat-ptr.rs -> not sure where to put this, but not binop
issue-18294.rs -> consts
issue-32201.rs -> c-variadic
issue-73886.rs -> coercion
unary-minus-suffix-inference.rs -> numbers-arithmetic
issue-37550-1.rs -> could you rename the moved file and not the file that is already in consts?
changing-crates.rs -> svh
nested_item_main.rs -> statics
issue-40962.rs -> attributes
issue-14837.rs -> lint
issue-8351-1.rs -> pattern
issue-8351-2.rs -> pattern
issue-14227.rs -> statics (the test regressed, it should use an unsafe block and produce a different error)
issue-28324.rs -> statics (the test regressed, it should use an unsafe block and produce a different error)
unnecessary-extern-crate.rs -> lint
argument-passing.rs -> can be removed
issue-15080.rs -> pattern
issue-3211.rs -> can be removed
issue-4401.rs -> can be removed
issue-63364.rs -> lint
terminate-in-initializer.rs -> drop
yield2.rs -> threads-sendsync
warn-ctypes-inhibit.rs -> lint
in-band-lifetimes.rs -> in-band-lifetimes
issue-26448-1.rs -> regions
issue-26448-2.rs -> regions
issue-26448-3.rs -> regions
issue-28871.rs -> associated-types
issue-3973.rs -> traits
issue-42463.rs -> closures
object-does-not-impl-trait.rs -> traits
issue-61882.rs -> self
issue-61882-2.rs -> self
issue-2748-b.rs -> can be removed
issue-42747.rs -> enum
lambda-var-hygiene.rs -> hygiene
issue-21475.rs -> parser
negative.rs -> can be removed
issue-57410-1.rs -> lint
issue-6804.rs -> rfc-1445-restrict-constants-in-patterns (for now)
issue-45152.rs -> the issue number is wrong, should actually be 46152
issue-2444.rs -> can be removed
issue-811.rs -> can be removed
issue-22463.rs -> macros
issue-3021-c.rs -> resolve
issue-59508.rs -> generics
issue-19163.rs -> macros
issue-39823.rs -> coercion
byte-literals.rs -> not sure where to put this, but not static
issue-16602-3.rs -> not sure where to put this, but not static, it's some kind of assignment codegen issue
issue-11577.rs -> pattern
issue-74739.rs -> mir
structured-compare.rs -> binop maybe
issue-5099.rs -> resolve
issue-14589.rs -> coercion
issue-19358.rs -> deriving
diverging-tuple-parts-39485.rs -> never_type
issue-13483.rs -> parser
issue-20616-4.rs -> parser
issue-20616-5.rs -> parser
issue-20616-6.rs -> parser
issue-20616-7.rs -> parser
issue-30355.rs -> unsized
issue-43189.rs -> typeck
issue-46112.rs -> typeck
issue-61711-once-caused-rustc-inf-loop.rs -> typeck

petrochenkov · 2021-10-10T21:12:30Z

Could you also update the limits in tidy?

c410-f3r · 2021-11-06T12:41:54Z

OK. I think I addressed all concerns but feel free to point any other misplacement.

c410-f3r · 2021-11-06T13:13:50Z

Couldn't reproduce the error locally for some reason

petrochenkov · 2021-11-06T18:11:10Z

issue-2748-b.rs (lifetime.rs after renaming) - still can be removed
byte-literals.rs - please don't remove this one
issue-16602-3.rs - please don't remove this one
issue-30355.rs -> unsized
issue-44005.rs - failing on CI, I think you can omit it from this PR

c410-f3r · 2021-11-06T18:21:35Z

issue-2748-b.rs (lifetime.rs after renaming) - still can be removed byte-literals.rs - please don't remove this one issue-16602-3.rs - please don't remove this one issue-30355.rs -> unsized issue-44005.rs - failing on CI, I think you can omit it from this PR

Done

petrochenkov · 2021-11-07T07:18:34Z

@bors r+

bors · 2021-11-07T07:18:36Z

📌 Commit 7fd15f0 has been approved by petrochenkov

bors · 2021-11-07T07:57:00Z

⌛ Testing commit 7fd15f0 with merge f5d9b9e3461096a3a2cd7797e31e755967aaed98...

bors · 2021-11-07T09:03:05Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-11-07T09:59:25Z

The job x86_64-msvc-cargo failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

test workspaces::ws_warn_unused ... ok
failures:
---- lto::complicated stdout ----
running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build -v --release`
thread 'lto::complicated' panicked at '
test failed running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe build -v --release`
error: process exited with code 101 (expected 0)
--- stderr
--- stderr
Updating `dummy-registry` index
---
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.
Compiling dep-shared v0.0.1
Compiling dep-build2 v0.0.1
Compiling dep-proc-macro2 v0.0.1
Compiling dep-normal2 v0.0.1
Running `rustc --crate-name dep_shared D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-shared-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C metadata=815663fa4ca118de -C extra-filename=-815663fa4ca118de --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --cap-lints allow`
Running `rustc --crate-name dep_normal2 D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-normal2-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C linker-plugin-lto -C metadata=8cf56e81cc7e8007 -C extra-filename=-8cf56e81cc7e8007 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --cap-lints allow`
Running `rustc --crate-name dep_proc_macro2 D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-proc-macro2-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=f829152b9eb79c53 -C extra-filename=-f829152b9eb79c53 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --cap-lints allow`
Running `rustc --crate-name dep_build2 D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-build2-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=df572682f4638748 -C extra-filename=-df572682f4638748 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --cap-lints allow`
Compiling dep-normal v0.0.1
Running `rustc --crate-name dep_normal D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-normal-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C linker-plugin-lto -C metadata=06ea447f8e785b1a -C extra-filename=-06ea447f8e785b1a --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_normal2=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_normal2-8cf56e81cc7e8007.rmeta --extern dep_shared=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_shared-815663fa4ca118de.rmeta --cap-lints allow`
Compiling dep-build v0.0.1
Running `rustc --crate-name dep_build D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-build-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=4b7343fd1f9e1e57 -C extra-filename=-4b7343fd1f9e1e57 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_build2=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_build2-df572682f4638748.rmeta --extern dep_shared=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_shared-815663fa4ca118de.rmeta --cap-lints allow`
Compiling dep-proc-macro v0.0.1
Running `rustc --crate-name dep_proc_macro D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\home\.cargo\registry\src\-80b16767b11d2893\dep-proc-macro-0.0.1\src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C opt-level=3 -C embed-bitcode=no -C metadata=92b443923583e648 -C extra-filename=-92b443923583e648 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_proc_macro2=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_proc_macro2-f829152b9eb79c53.rlib --extern dep_shared=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_shared-815663fa4ca118de.rlib --extern proc_macro --cap-lints allow`
Compiling test v0.0.0 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo)
Running `rustc --crate-name build_script_build build.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C opt-level=3 -C embed-bitcode=no -C metadata=1132ccd72abf6ae6 -C extra-filename=-1132ccd72abf6ae6 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\build\test-1132ccd72abf6ae6 -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_build=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_build-4b7343fd1f9e1e57.rlib`
Running `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\build\test-1132ccd72abf6ae6\build-script-build`
Running `rustc --crate-name test src\main.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C opt-level=3 -C lto -C metadata=f9bd7972e02c2e3b --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_normal=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_normal-06ea447f8e785b1a.rlib --extern dep_proc_macro=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\dep_proc_macro-92b443923583e648.dll`
Running `rustc --crate-name test src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type cdylib --crate-type staticlib --emit=dep-info,link -C opt-level=3 -C lto -C metadata=10d13534f609fec7 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_normal=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_normal-06ea447f8e785b1a.rlib --extern dep_proc_macro=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\dep_proc_macro-92b443923583e648.dll`
error: linking with `link.exe` failed: exit code: 1201
|
= note: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe" "/DEF:C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcWVdGEO\\lib.def" "/NOLOGO" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1287\\foo\\target\\release\\deps\\test.test.3b04ecf7-cgu.0.rcgu.o" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1287\\foo\\target\\release\\deps" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-2bd9c3b9b2394772.rlib" "kernel32.lib" "ws2_32.lib" "bcrypt.lib" "advapi32.lib" "userenv.lib" "kernel32.lib" "msvcrt.lib" "/NXCOMPAT" "/LIBPATH:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1287\\foo\\target\\release\\deps\\test.dll" "/OPT:REF,ICF" "/DLL" "/IMPLIB:D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\cit\\t1287\\foo\\target\\release\\deps\\test.dll.lib" "/DEBUG"
= note: LINK : fatal error LNK1201: error writing to program database 'D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\test.pdb'; check for insufficient disk space, invalid path, or insufficient privilege
error: could not compile `test` due to previous error
Caused by:
Caused by:
process didn't exit successfully: `rustc --crate-name test src\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type cdylib --crate-type staticlib --emit=dep-info,link -C opt-level=3 -C lto -C metadata=10d13534f609fec7 --out-dir D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps -L dependency=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps --extern dep_normal=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\libdep_normal-06ea447f8e785b1a.rlib --extern dep_proc_macro=D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\dep_proc_macro-92b443923583e648.dll` (exit code: 1)
error: build failed
', src\tools\cargo\tests\testsuite\lto.rs:217:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

c410-f3r · 2021-11-07T11:41:13Z

 = note: LINK : fatal error LNK1201: error writing to program database 'D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t1287\foo\target\release\deps\test.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

Spurious error?

matthiaskrgr · 2021-11-07T11:53:39Z

@bors retry

bors · 2021-11-08T02:04:35Z

⌛ Testing commit 7fd15f0 with merge 43192ca...

bors · 2021-11-08T05:13:35Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 43192ca to master...

rust-timer · 2021-11-08T06:44:33Z

Finished benchmarking commit (43192ca): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rust-highfive assigned petrochenkov Oct 3, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2021

This comment has been minimized.
Sign in to view

c410-f3r force-pushed the testsssssss branch from bc1f074 to ce180a5Compare October 3, 2021 13:31

This comment has been minimized.
Sign in to view

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2021

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 21, 2021

c410-f3r force-pushed the testsssssss branch from ce180a5 to c5f2e88Compare November 6, 2021 12:40

This comment has been minimized.
Sign in to view

c410-f3r force-pushed the testsssssss branch from c5f2e88 to fee1e74Compare November 6, 2021 18:21

c410-f3r force-pushed the testsssssss branch from fee1e74 to d20780dCompare November 6, 2021 18:23

Move some tests to more reasonable directories
7fd15f0

c410-f3r force-pushed the testsssssss branch from d20780d to 7fd15f0Compare November 6, 2021 18:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2021

bors merged commit 43192ca into rust-lang:masterNov 8, 2021

rustbot added this to the 1.58.0 milestone Nov 8, 2021

This was referenced Nov 8, 2021
Introduce linter for diagnostic messages #89455
Closed
Include rustc version in rustc_span::StableCrateId#89836
Merged
Improve suggestions for compatible variants on type mismatch. #90575
Merged

jfrimmel mentioned this pull request Nov 10, 2021
Re-enable copy[_nonoverlapping]() debug-checks #90041
Merged

SabrinaJewson mentioned this pull request Feb 8, 2022
Fix link to the Bastion of the Turbofish rust-lang/reference#1161
Merged

Uh oh!

Uh oh!

Conversation

c410-f3r commented Oct 3, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Oct 10, 2021

Uh oh!

petrochenkov commented Oct 10, 2021

Uh oh!

c410-f3r commented Nov 6, 2021

Uh oh!

This comment has been minimized.

c410-f3r commented Nov 6, 2021

Uh oh!

petrochenkov commented Nov 6, 2021

Uh oh!

c410-f3r commented Nov 6, 2021

Uh oh!

petrochenkov commented Nov 7, 2021

Uh oh!

bors commented Nov 7, 2021

Uh oh!

bors commented Nov 7, 2021

Uh oh!

bors commented Nov 7, 2021

Uh oh!

rust-log-analyzer commented Nov 7, 2021

Uh oh!

c410-f3r commented Nov 7, 2021

Uh oh!

matthiaskrgr commented Nov 7, 2021

Uh oh!

bors commented Nov 8, 2021

Uh oh!

bors commented Nov 8, 2021

Uh oh!

rust-timer commented Nov 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants