Remove textual span from diagnostic string by oli-obk · Pull Request #89555 · rust-lang/rust

oli-obk · 2021-10-05T12:14:27Z

This is an unnecessary repetition, as the diagnostic prints the span anyway in the source path right below the message.

I further removed the identification of the node, as that does not give any new information in any of the cases that are changed in tests.

EDIT: also inserted a suggestion that other diagnostics were already emitting

rust-highfive · 2021-10-05T12:14:30Z

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

estebank · 2021-10-07T09:48:59Z

 LL | fn hide_ref<'a, 'b, T: 'static>(x: &'a mut &'b T) -> impl Swap + 'a {
- | ^^^^^^^^^^^^^^
+ | -- ^^^^^^^^^^^^^^
+ | |
+ | hidden type `&'a mut &'b T` captures the lifetime `'b` as defined here


Should we mention that "hidden type &'a mut &'b T" is impl Swap + 'a in some way? Either with a label on the primary span or mentioning it explicitly in a note? (Doesn't need to be addressed in this PR)

I'll also wait with this until the primary span stops pointing to the return type with lazy TAIT

estebank · 2021-10-07T09:50:39Z

 error[E0700]: hidden type for `impl Trait` captures lifetime that does not appear in bounds
- --> $DIR/error-handling-2.rs:13:60
+ --> $DIR/error-handling-2.rs:10:60
 |
 LL | fn foo<'a: 'b, 'b, 'c>(x: &'static i32, mut y: &'a i32) -> E<'b, 'c> {
- | ^^^^^^^^^
- |
-note: hidden type `*mut &'a i32` captures the lifetime `'a` as defined on the function body at 13:8
- --> $DIR/error-handling-2.rs:13:8
- |
-LL | fn foo<'a: 'b, 'b, 'c>(x: &'static i32, mut y: &'a i32) -> E<'b, 'c> {
- | ^^
+ | -- ^^^^^^^^^
+ | |
+ | hidden type `*mut &'a i32` captures the lifetime `'a` as defined here


In this case, then we should maybe have a label pointing at the type E definition saying "this is the hidden type", if we do what I mentioned earlier?

I am not sure. Is is helpful to know where the opaque type is declared? If it were a struct or just a regular type alias, we would not be pointing at the definition either.
I could see it making sense to point at the definition for trait bound mismatches, as these are only written at the definition, but all the lifetimes are local to this function and could have confusingly different names on the declaration

What about having a primary span saying "hiden type returned here" or something along those lines?

🤣 yes, that is exactly what we need, but without lazy TAIT that is going to be a pain to figure out... or... hmm maybe not, I have an idea

The idea would kind of work, but it's horrible and not something to do quickly

I'll love to hear about it ☺️

estebank · 2021-10-07T10:10:53Z

r? @estebank

r=me with or without the nitpicks addressed (I see that this is blocking another PR, so if you don't want to deal with it we can create an E-easy ticket for someone else to tackle it)

oli-obk · 2021-10-08T15:56:31Z

@bors r=estebank

bors · 2021-10-08T15:56:32Z

📌 Commit d3871f5 has been approved by estebank

… r=estebank Remove textual span from diagnostic string This is an unnecessary repetition, as the diagnostic prints the span anyway in the source path right below the message. I further removed the identification of the node, as that does not give any new information in any of the cases that are changed in tests. EDIT: also inserted a suggestion that other diagnostics were already emitting

camelid · 2021-10-08T18:16:32Z

@bors r-

Failed in rollup: #89671 (comment)

Looks like some more tests may need to be blessed.

oli-obk · 2021-10-08T18:31:09Z

@bors r=estebank

bors · 2021-10-08T18:31:10Z

📌 Commit 09d1774 has been approved by estebank

… r=estebank Remove textual span from diagnostic string This is an unnecessary repetition, as the diagnostic prints the span anyway in the source path right below the message. I further removed the identification of the node, as that does not give any new information in any of the cases that are changed in tests. EDIT: also inserted a suggestion that other diagnostics were already emitting

GuillaumeGomez · 2021-10-09T15:08:04Z

Failed in #89702.

@bors: r-

camelid · 2021-10-09T16:37:40Z

@bors rollup=iffy

oli-obk · 2021-10-12T15:48:14Z

@bors r=estebank

bors · 2021-10-12T15:48:15Z

📌 Commit 724bc1cbd3161ab1581ab54789807731f3628056 has been approved by estebank

bors · 2021-10-13T09:59:57Z

⌛ Testing commit 724bc1cbd3161ab1581ab54789807731f3628056 with merge 8e9f48623c91b6baadd21004928795845c9baa98...

bors · 2021-10-13T10:38:05Z

💔 Test failed - checks-actions

… on an impl trait

oli-obk · 2021-10-13T11:06:30Z

@bors r=estebank

bors · 2021-10-13T11:06:31Z

📌 Commit 20d6aad has been approved by estebank

bors · 2021-10-13T20:36:13Z

⌛ Testing commit 20d6aad with merge dfc5add...

bors · 2021-10-13T23:27:51Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing dfc5add to master...

rust-timer · 2021-10-14T01:50:43Z

Finished benchmarking commit (dfc5add): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

Moderate improvement in instruction counts (up to -0.9% on full builds of diesel)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

oli-obk added the A-diagnostics Area: Messages for errors, warnings, and lints label Oct 5, 2021

rust-highfive assigned jackh726 Oct 5, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2021

oli-obk mentioned this pull request Oct 6, 2021
Remove redundant member-constraint check #89229
Merged

estebank reviewed Oct 7, 2021
View reviewed changes

rust-highfive assigned estebank and unassigned jackh726 Oct 7, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2021

GuillaumeGomez mentioned this pull request Oct 8, 2021
Rollup of 6 pull requests #89671
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2021

GuillaumeGomez mentioned this pull request Oct 9, 2021
Rollup of 7 pull requests #89702
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2021

oli-obk force-pushed the nll_member_constraint_diag branch from 09d1774 to 724bc1cCompare October 12, 2021 15:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 12, 2021

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2021

oli-obk added 7 commits October 13, 2021 10:53

Remove textual span from diagnostic string
15f9347

Use a label instead of a note for member constraint errors
d435101

Remove a feature attribute for an accepted feature
56e79e6

Remove explicit -Zborrowck=mir which does not affect test anymore
be39963

Re-use logic for adding a suggestion when a lifetime bound is missing…
888ba50
… on an impl trait

Bless nll tests
ab7721d

Update clippy ui output
20d6aad

oli-obk force-pushed the nll_member_constraint_diag branch from 724bc1c to 20d6aadCompare October 13, 2021 11:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 13, 2021

bors merged commit dfc5add into rust-lang:masterOct 13, 2021

rustbot added this to the 1.57.0 milestone Oct 13, 2021

pnkfelix mentioned this pull request Dec 8, 2021
doc test "Couldn't compile the test" on aarch64 + LTO #91671
Closed

Uh oh!

Uh oh!

Conversation

oli-obk commented Oct 5, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Oct 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estebank commented Oct 7, 2021

Uh oh!

oli-obk commented Oct 8, 2021

Uh oh!

bors commented Oct 8, 2021

Uh oh!

camelid commented Oct 8, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Oct 8, 2021

Uh oh!

bors commented Oct 8, 2021

Uh oh!

GuillaumeGomez commented Oct 9, 2021

Uh oh!

camelid commented Oct 9, 2021

Uh oh!

oli-obk commented Oct 12, 2021

Uh oh!

bors commented Oct 12, 2021

Uh oh!

bors commented Oct 13, 2021

Uh oh!

This comment has been minimized.

bors commented Oct 13, 2021

Uh oh!

oli-obk commented Oct 13, 2021

Uh oh!

bors commented Oct 13, 2021

Uh oh!

bors commented Oct 13, 2021

Uh oh!

bors commented Oct 13, 2021

Uh oh!

rust-timer commented Oct 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

oli-obk commented Oct 5, 2021•
edited
Loading

camelid commented Oct 8, 2021•
edited
Loading