Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #89683
Merged
Merged
Conversation
It was marking them up as `<span class="op">=</span><span class="op">></span>`, which is bloaty and wrong.
…, r=jackh726 Don't normalize xform_ret_ty during method candidate assembly Fixesrust-lang#85671 Normalizing the return type of a method candidate together with the expected receiver type of the method can lead to valid method candidates being rejected during probing. Specifically in the example of the fixed issue we have a `self_ty` of the form `&A<&[Coef]>` whereas the `impl_ty` of the method would be `&A<_>`, if we normalize the projection in the return type we unify the inference variable with `Cont`, which will lead us to reject the candidate in the sup type check in `consider_probe`. Since we don't actually need the normalized return type during candidate assembly, we postpone the normalization until we consider candidates in `consider_probe`.
…, r=GuillaumeGomez Make rustdoc not highlight `->` and `=>` as operators It was marking them up as `<span class="op">=</span><span class="op">></span>`, which is bloaty and wrong (at least, I think `<=` and `=>` should probably be different colors, since they're so different and yet made from the same symbols). Before:  After: 
clippy::complexity fixes
Cfg hide more conditions for core and alloc Fixesrust-lang#89663 Before:  After:  *Same for alloc* r? ``@GuillaumeGomez``
…llaumeGomez Remove special-casing of never primitive in rustdoc-json-types Fixesrust-lang#89349 r? `@GuillaumeGomez`
Remove unwrap_or! macro Removes `unwrap_or!` macro and replaces it with `match`. It's kinda cleanup, as rustc_ast not the best place for this macro and this is used only in 2 places anyway.
GuillaumeGomez
commented
Oct 8, 2021
MemberAuthor
@bors: r+ p=6 rollup=never |
bors
commented
Oct 8, 2021
Collaborator
📌 Commit cda07c7 has been approved by |
bors
commented
Oct 8, 2021
Collaborator
bors
commented
Oct 9, 2021
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Oct 9, 2021
Collaborator
Finished benchmarking commit (f875143): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
->and=>as operators #89538 (Make rustdoc not highlight->and=>as operators)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup