Uh oh!
There was an error while loading. Please reload this page.
Move top part of print_item to Tera templates - #89695
Conversation
Add print_item.html and the code in print_item.rs to use it.
rust-highfive
commented
Oct 9, 2021
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
commented
Oct 9, 2021
Thanks for the PR and the answers! r=me once CI pass |
jsha
commented
Oct 9, 2021
@bors r=GuillaumeGomez rollup |
bors
commented
Oct 9, 2021
📌 Commit d0a33fb has been approved by |
GuillaumeGomez
commented
Oct 9, 2021
Since it can impact performance, let's not put it into the rollup. @bors: rollup=iffy |
bors
commented
Oct 10, 2021
bors
commented
Oct 10, 2021
☀️ Test successful - checks-actions |
rust-timer
commented
Oct 10, 2021
Finished benchmarking commit (c1cb974): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
GuillaumeGomez
commented
Oct 10, 2021
@jsha: It's a big regression for doc build time... Time for optimization I guess. :) |
Part of #84419.
This moves the first line of each item page (E.g.
Struct foo::Bar .... 1.0.0 [-][src]into a Tera template.I also moved template initialization into its own module and added a small macro to reduce duplication and opportunity for errors.