Skip to content

Fix invalid HTML generation for higher bounds - #89700

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-rustdoc-higher-bound-html-gen
Oct 9, 2021
Merged

Fix invalid HTML generation for higher bounds#89700
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-rustdoc-higher-bound-html-gen

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Considering this is a bug, I cherry-picked the commit from #89676 so it's merged more quickly.

r? @notriddle

@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Oct 9, 2021
@notriddle

Copy link
Copy Markdown
Contributor

I’m really looking forward to when rustdoc finished switching to Tera.

@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

I'm still having reserve about tera, mostly about the size of the generated HTML. They insert a lot of useless whitespaces, which is kinda problematic when done too many times...

@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors: r=notriddle rollup

@bors

bors commented Oct 9, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 3214253 has been approved by notriddle

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 9, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 9, 2021
…ound-html-gen, r=notriddle
Fix invalid HTML generation for higher bounds
Considering this is a bug, I cherry-picked the commit from rust-lang#89676 so it's merged more quickly.
r? `@notriddle`
This was referenced Oct 9, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2021
…laumeGomez
Rollup of 6 pull requests
Successful merges:
- rust-lang#75644 (Add 'core::array::from_fn' and 'core::array::try_from_fn')
- rust-lang#87528 (stack overflow handler specific openbsd change.)
- rust-lang#88436 (std: Stabilize command_access)
- rust-lang#89614 (Update to Unicode 14.0)
- rust-lang#89664 (Add documentation to boxed conversions)
- rust-lang#89700 (Fix invalid HTML generation for higher bounds)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3e93472 into rust-lang:masterOct 9, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 9, 2021
@GuillaumeGomez
GuillaumeGomez deleted the fix-rustdoc-higher-bound-html-gen branch October 9, 2021 19:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@notriddle@bors@rustbot