Add long explanation for error E0482 by sireliah · Pull Request #89710 · rust-lang/rust

sireliah · 2021-10-09T19:33:03Z

This is longer explanation for error E0482 in the #61137.

Please take a look and leave some feedback!

rust-highfive · 2021-10-09T19:33:05Z

Some changes occurred in diagnostic error codes

rust-highfive · 2021-10-09T19:33:06Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

GuillaumeGomez · 2021-10-10T09:47:00Z

+}
+```
+
+[`impl Trait`] feature in return type have implicit `'static` lifetime


Suggested change
[`impl Trait`] feature in return type have implicit `'static` lifetime
The [`impl Trait`] feature uses an implicit `'static` lifetime restriction in the returned type

I fixed that part and split the sentence in two. I also made it sound different, because before the explanation sounded like all -> impl Trait structures force 'static lifetime in all cases (like Box<Trait>), which is not true according to RFC I believe.
Those can be different lifetimes and only my example required 'static. Please correct me if I'm wrong @GuillaumeGomez or @nagisa.

GuillaumeGomez · 2021-10-10T09:51:20Z

 const EXEMPTED_FROM_TEST: &[&str] = &[
 "E0227", "E0279", "E0280", "E0313", "E0377", "E0461", "E0462", "E0464", "E0465", "E0476",
- "E0482", "E0514", "E0519", "E0523", "E0554", "E0640", "E0717", "E0729",
+ "E0514", "E0519", "E0523", "E0554", "E0640", "E0717", "E0729",


nagisa · 2021-10-10T21:16:44Z

r? @GuillaumeGomez

GuillaumeGomez · 2021-10-11T19:46:22Z

Once these are done, I think it'll be good to be merged.

GuillaumeGomez · 2021-10-11T19:53:00Z

Thanks!

@bors: r+ rollup

bors · 2021-10-11T19:53:02Z

📌 Commit 0fde6f6 has been approved by GuillaumeGomez

sireliah · 2021-10-11T19:57:10Z

Thanks for the review @GuillaumeGomez!

…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#89471 (Use Ancestory to check default fn in const impl instead of comparing idents) - rust-lang#89643 (Fix inherent impl overlap check.) - rust-lang#89651 (Add `Poll::ready` and revert stabilization of `task::ready!`) - rust-lang#89675 (Re-use TypeChecker instead of passing around some of its fields ) - rust-lang#89710 (Add long explanation for error E0482) - rust-lang#89756 (Greatly reduce amount of debuginfo compiled for bootstrap itself) - rust-lang#89760 (Remove hack ignoring unused attributes for stage 0 std) - rust-lang#89772 (Fix function-names test for GDB 10.1) - rust-lang#89785 (Fix ICE when compiling nightly std/rustc on beta compiler) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned nagisa Oct 9, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2021

This comment has been minimized.
Sign in to view

Add long explanation for error E0482
a94e39e

sireliah force-pushed the e0482 branch from 10b9440 to a94e39eCompare October 9, 2021 19:49

Allow the E0482 to be tested
14aae67

GuillaumeGomez reviewed Oct 10, 2021
View reviewed changes

Comment threadcompiler/rustc_error_codes/src/error_codes/E0482.md

GuillaumeGomez reviewed Oct 10, 2021
View reviewed changes