Uh oh!
There was an error while loading. Please reload this page.
Add #[must_use] to core and std constructors - #89729
Merged
Merged
Conversation
ContributorAuthor
Heads up, I threw core::mem::MaybeUninit<T> const fn uninit() -> MaybeUninit<T>;
core::mem::MaybeUninit<T> const fn uninit_array<constLEN: usize>() -> [Self;LEN];
core::mem::MaybeUninit<T> fn zeroed() -> MaybeUninit<T>;I left |
joshtriplett
commented
Oct 11, 2021
Member
I do think it's reasonable to add the annotation to MaybeUninit::new as well, but that can happen in another PR. Suggesting mem::forget sounds good. |
joshtriplett
commented
Oct 11, 2021
Member
@bors r+ |
bors
commented
Oct 11, 2021
Collaborator
📌 Commit 5b5c12b has been approved by |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 11, 2021
…ctors, r=joshtriplett Add #[must_use] to core and std constructors Parent issue: rust-lang#89692 r? `@joshtriplett`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#89655 (bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts) - rust-lang#89726 (Add #[must_use] to alloc constructors) - rust-lang#89729 (Add #[must_use] to core and std constructors) - rust-lang#89743 (Fix RUSTC_LOG handling) - rust-lang#89753 (Add #[must_use] to from_value conversions) - rust-lang#89754 (Cleanup .item-table CSS) - rust-lang#89761 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 11, 2021
…, r=joshtriplett Add #[must_use] to MaybeUninit::new As discussed in rust-lang#89729 (comment). Parent issue: rust-lang#89692 r? `@joshtriplett`
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2021
…, r=joshtriplett Add #[must_use] to MaybeUninit::new As discussed in rust-lang#89729 (comment). Parent issue: rust-lang#89692 r? ``@joshtriplett``
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2021
…r=joshtriplett Add #[must_use] to MaybeUninit::new As discussed in rust-lang#89729 (comment). Parent issue: rust-lang#89692 r? `@joshtriplett`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: #89692
r? @joshtriplett