Skip to content

Add #[must_use] to len and is_empty - #89786

Merged
bors merged 1 commit into
rust-lang:masterfrom
jkugelman:must-use-len-and-is_empty
Oct 31, 2021
Merged

Add #[must_use] to len and is_empty#89786
bors merged 1 commit into
rust-lang:masterfrom
jkugelman:must-use-len-and-is_empty

Conversation

@jkugelman

@jkugelmanjkugelman commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

Parent issue: #89692

r? @joshtriplett

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2021
@jkugelmanjkugelman mentioned this pull request Oct 11, 2021
Closed
joshtriplett
joshtriplett reviewed Oct 11, 2021
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/set/tests.rs Outdated
@joshtriplett

joshtriplett commented Oct 11, 2021

Copy link
Copy Markdown
Member

r=me with the nit fixed in the tests.

@jkugelman
jkugelmanforce-pushed the must-use-len-and-is_empty branch from 229f707 to 64bb2c1CompareOctober 11, 2021 21:21
@joshtriplett

joshtriplett commented Oct 11, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 11, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 64bb2c1 has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2021
@joshtriplettjoshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 11, 2021
@the8472the8472 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 11, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2021
@matthiaskrgr
Rollup merge ofrust-lang#89786- jkugelman:must-use-len-and-is_empty…
d04357a
…, r=joshtriplett
Add #[must_use] to len and is_empty
Parent issue: rust-lang#89692
r? `@joshtriplett`
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 12, 2021
Closed
the8472 added a commit to the8472/rust that referenced this pull request Oct 12, 2021
@the8472
Rollup merge ofrust-lang#89786- jkugelman:must-use-len-and-is_empty…
84e3828
…, r=joshtriplett
Add #[must_use] to len and is_empty
Parent issue: rust-lang#89692
r? ``@joshtriplett``
@the8472the8472 mentioned this pull request Oct 12, 2021
Closed
@the8472

the8472 commented Oct 12, 2021

Copy link
Copy Markdown
Member

Looks like this failed a rollup in #89801 (comment)

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2021
@jkugelman
jkugelmanforce-pushed the must-use-len-and-is_empty branch from 64bb2c1 to c509346CompareOctober 12, 2021 13:10
@jkugelman

jkugelman commented Oct 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Clippy test fixed and blessed. I'll make sure to run the Clippy test suite in my future PRs since CI doesn't seem to catch them.

How did this make it past the CI checks? Should I submit an issue against the CI system?

@jkugelman

jkugelman commented Oct 12, 2021

Copy link
Copy Markdown
ContributorAuthor

It looks like the clippy tests are only run for individual PRs if something in clippy has changed. They're not run for all PRs because it would add too much CI time.

#77016

This runs the tools builder (which builds and tests tools, including clippy) when the clippy submodule changes. This essentially returns us to the prior state when clippy was a submodule; it makes sense for us to test it on CI when it changes. It might make sense for it to be tested regardless of changing but it is somewhat rare for it to fail and we don't want to add to CI time for the majority of PRs which don't affect it.

the8472
the8472 reviewed Oct 12, 2021
View reviewed changes
Comment threadsrc/tools/clippy/tests/ui/iter_count.rs Outdated

@the8472the8472Oct 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for tests it would be fine to just supress the warning instead of adding tons of let _.

@jkugelmanjkugelmanOct 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @joshtriplett.

@joshtriplettjoshtriplettOct 12, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer adding let _ =, but I don't have a strong preference, and if the maintainer of these tests prefers to suppress the lint that's fine.

@jkugelmanjkugelmanOct 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who's the maintainer? Do I have an action?

@joshtriplettjoshtriplettOct 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference, so go ahead and switch this one to suppress the lint.

@jkugelmanjkugelmanOct 30, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jkugelman
jkugelmanforce-pushed the must-use-len-and-is_empty branch from c509346 to 6745e8dCompareOctober 30, 2021 23:25
@joshtriplett

joshtriplett commented Oct 31, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 6745e8d has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2021
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 31, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2021
@bors
Auto merge ofrust-lang#90437- matthiaskrgr:rollup-vd8uqm6, r=matthi…
68b554e
…askrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#89068 (Restructure std::rt (part 2))
- rust-lang#89786 (Add #[must_use] to len and is_empty)
- rust-lang#90430 (Add #[must_use] to remaining std functions (A-N))
- rust-lang#90431 (Add #[must_use] to remaining std functions (O-Z))
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 88e5ae2 into rust-lang:masterOct 31, 2021
@rustbotrustbot added this to the 1.58.0 milestone Oct 31, 2021
@jkugelman
jkugelman deleted the must-use-len-and-is_empty branch October 31, 2021 17:35
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 4, 2021
@matthiaskrgr
Rollup merge ofrust-lang#89786- jkugelman:must-use-len-and-is_empty…
d634fae
…, r=joshtriplett
Add #[must_use] to len and is_empty
Parent issue: rust-lang#89692
r? `@joshtriplett`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtriplettjoshtriplettjoshtriplett left review comments
@the8472the8472the8472 left review comments

Assignees

@joshtriplettjoshtriplett

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jkugelman@joshtriplett@bors@the8472@rust-highfive@rustbot