Add `slice::{from_ptr_range, from_mut_ptr_range} ` by ibraheemdev · Pull Request #89793 · rust-lang/rust

ibraheemdev · 2021-10-11T21:52:43Z

Adds slice::{from_ptr_range, from_mut_ptr_range} as counterparts to slice::{as_ptr_range, as_mut_ptr_range}.

rust-highfive · 2021-10-11T21:52:46Z

(rust-highfive has picked a reviewer for you, use r? to override)

bors · 2021-10-15T12:52:00Z

☔ The latest upstream changes (presumably #88540) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2021-12-01T23:44:39Z

☔ The latest upstream changes (presumably #91433) made this pull request unmergeable. Please resolve the merge conflicts.

ibraheemdev · 2022-02-24T14:55:56Z

@m-ou-se can you review this when you have the time, or should it be assigned to someone else?

m-ou-se

Apologies.

This looks good to me.

There is just one issue that worries me: There have been (incomplete) plans for quite a while to replace Range by two types: One that is Copy, and one that is an iterator. Using Range in signatures like this makes that change a little bit harder than it already is. Of course, the existing (and stable) .as_ptr_range() already has this problem as it uses Range as its return type. Still, I'm worried about making a potential change to Range even harder by adding the functions in this PR.

That doesn't have to stand in the way of adding these as unstable. I have added this as an unresolved question to the tracking issue, so we can make sure to address it before stabilizing this.

If you can fix the merge conflict, this is ready to merge.

ibraheemdev · 2022-02-24T23:55:20Z

Fixed @m-ou-se

m-ou-se · 2022-02-25T12:00:29Z

Can you rebase/squash the commits? Because now there's a commit named "update rust-analyzer submodule", which shouldn't be part of this PR.

ibraheemdev · 2022-02-27T21:24:27Z

squashed @m-ou-se

m-ou-se · 2022-02-28T11:03:33Z

@bors r+ rollup

bors · 2022-02-28T11:03:35Z

📌 Commit aac0281 has been approved by m-ou-se

…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#89793 (Add `slice::{from_ptr_range, from_mut_ptr_range} `) - rust-lang#92642 (Update search location from a relative path to absolute) - rust-lang#93389 (regression for issue 90847) - rust-lang#93413 (Fix broken link from rustdoc docs to ayu theme) - rust-lang#94365 (Fix MinGW target detection in raw-dylib) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned m-ou-se Oct 11, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2021

ibraheemdev mentioned this pull request Oct 11, 2021
Tracking Issue for slice_from_ptr_range#89792
Open
5 tasks

the8472 reviewed Oct 11, 2021
View reviewed changes

Comment threadlibrary/core/src/slice/raw.rs Outdated