Uh oh!
There was an error while loading. Please reload this page.
Don't mark for loop iter expression as desugared - #89895
Merged
Merged
Conversation
rust-highfive
commented
Oct 14, 2021
Contributor
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
commented
Oct 14, 2021
Contributor
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
camsteffenforce-pushed
the
for-loop-head-span
branch
from
October 14, 2021 23:58
e7d5bc8 to
aeaf28cCompare
This comment has been minimized.
This comment has been minimized.
camsteffenforce-pushed
the
for-loop-head-span
branch
from
October 15, 2021 07:22
aeaf28c to
190607dCompare
This comment has been minimized.
This comment has been minimized.
camsteffenforce-pushed
the
for-loop-head-span
branch
from
October 15, 2021 13:04
190607d to
ffdd5a0Comparecamsteffen
commented
Oct 15, 2021
ContributorAuthor
I guess I improved incremental compilation by using more lowered spans but I'm not familiar with incremental. |
davidtwco
commented
Oct 21, 2021
Member
@bors r+ |
bors
commented
Oct 21, 2021
Collaborator
📌 Commit ffdd5a0 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 22, 2021
…vidtwco Don't mark for loop iter expression as desugared We typically don't mark spans of lowered things as desugared. This helps Clippy rightly discern when code is (not) from expansion. This was discovered by `@flip1995` at rust-lang/rust-clippy#7789 (comment).
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 22, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#87537 (Clarify undefined behaviour in binary heap, btree and hashset docs) - rust-lang#88624 (Stabilize feature `saturating_div` for rust 1.58.0) - rust-lang#89257 (Give better error for `macro_rules name`) - rust-lang#89665 (Ensure that pushing empty path works as before on verbatim paths) - rust-lang#89895 (Don't mark for loop iter expression as desugared) - rust-lang#89922 (Update E0637 description to mention `&` w/o an explicit lifetime name) - rust-lang#89944 (Change `Duration::[try_]from_secs_{f32, f64}` underflow error) - rust-lang#89991 (rustc_ast: Turn `MutVisitor::token_visiting_enabled` into a constant) - rust-lang#90028 (Reject closures in patterns) - rust-lang#90069 (Fix const qualification when executed after promotion) - rust-lang#90078 (Add a regression test for issue-83479) - rust-lang#90114 (Add some tests for const_generics_defaults) - rust-lang#90115 (Add test for issue rust-lang#78561) - rust-lang#90129 (triagebot: Treat `I-*nominated` like `I-nominated`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
…vidtwco Don't mark for loop iter expression as desugared We typically don't mark spans of lowered things as desugared. This helps Clippy rightly discern when code is (not) from expansion. This was discovered by ``@flip1995`` at rust-lang/rust-clippy#7789 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We typically don't mark spans of lowered things as desugared. This helps Clippy rightly discern when code is (not) from expansion. This was discovered by @flip1995 at rust-lang/rust-clippy#7789 (comment).