Remove FIXME since there is nothing to be fixed by GuillaumeGomez · Pull Request #89907 · rust-lang/rust

GuillaumeGomez · 2021-10-15T10:05:20Z

Resolves#88593.

The errors are deduplicated when displayed to users. They only appear
multiple times in UI tests.

jyn514

Haven't looked at the test case, but the abort_if_errors() call looks right.

camelid · 2021-10-15T18:14:13Z

It has one downsize though: rustdoc errors are now run in a "different pass", which I find not great...

What does this mean? Do you mean that if there was a rustc error, no rustdoc errors will be reported until the rustc error is fixed?

GuillaumeGomez · 2021-10-15T18:23:27Z

Exactly. For example, in the test I splitted in two parts, it's because the rustdoc lints weren't emitted because we aborted before them.

Mark-Simulacrum · 2021-10-15T18:28:19Z

rustc itself generally deduplicates errors, that's just turned off for UI tests. Does this duplication reproduce outside of UI tests? If not, it may be preferable to avoid the early abort, which we're generally trying to move away from where possible.

camelid · 2021-10-15T18:26:07Z

Suggested change
tcx.sess.abort_if_errors();
// Avoid emitting duplicate errors later on.
tcx.sess.abort_if_errors();

camelid · 2021-10-15T18:28:43Z

I think this is unrelated to this change, but why did it not emit missing_docs for the crate before?
Seems like the situation is this:
Before
function
After
crate
function

The rustc lint passes come afterwards (unless I missed something?).

camelid · 2021-10-15T18:32:07Z

rustc itself generally deduplicates errors, that's just turned off for UI tests. Does this duplication reproduce outside of UI tests? If not, it may be preferable to avoid the early abort, which we're generally trying to move away from where possible.

Huh, you're right; it doesn't seem to reproduce outside of UI tests. I thought I had found it "in the wild", but perhaps not.

camelid · 2021-10-15T18:33:34Z

I guess this PR and associated issue can be closed then?

camelid · 2021-10-15T18:33:54Z

Or maybe just repurpose this PR so it removes the FIXME in the test.

GuillaumeGomez · 2021-10-15T18:41:36Z

As you prefer. I personally don't have preference here. Just like the borrow checker comes after the other checks, I don't see it abnormal to have the rustdoc checks only if rustc is happy.

camelid · 2021-10-15T18:47:07Z

As you prefer. I personally don't have preference here. Just like the borrow checker comes after the other checks, I don't see it abnormal to have the rustdoc checks only if rustc is happy.

It'd be better to have as many errors as possible be reported in one build, as long as none are spurious. So I don't see why we should add this early abort, especially if T-compiler (or whichever team Mark was referring to) is moving away from it.

The borrow checker not running if earlier stages failed is just a technical limitation IIUC.

GuillaumeGomez · 2021-10-15T18:48:36Z

Then I'll update the PR to remove the FIXME. :)

GuillaumeGomez · 2021-10-15T19:38:01Z

And done!

camelid · 2021-10-16T20:12:44Z

r=me with the commit message amended to include something like this:

The errors are deduplicated when displayed to users. They only appear
multiple times in UI tests.

The errors are deduplicated when displayed to users. They only appear multiple times in UI tests.

GuillaumeGomez · 2021-10-16T20:15:32Z

Done!

camelid · 2021-10-16T20:18:58Z

Thanks!

@bors r+ rollup

bors · 2021-10-16T20:19:00Z

📌 Commit 7bad85e has been approved by camelid

camelid · 2021-10-16T20:36:29Z

@bors r+

bors · 2021-10-16T20:36:31Z

📌 Commit 7bad85e has been approved by camelid

…s, r=camelid Remove FIXME since there is nothing to be fixed Resolvesrust-lang#88593. The errors are deduplicated when displayed to users. They only appear multiple times in UI tests. cc `@jyn514` r? `@camelid`

Rollup of 7 pull requests Successful merges: - rust-lang#89507 (Add `#[repr(i8)]` to `Ordering`) - rust-lang#89849 (CI: Selecting the Xcode version no longer needed with the macos-11 runners.) - rust-lang#89886 (Update the wasi-libc built with the wasm32-wasi target) - rust-lang#89907 (Remove FIXME since there is nothing to be fixed) - rust-lang#89943 (clippy::complexity fixes) - rust-lang#89953 (Make Option::as_mut const) - rust-lang#89958 (Correct small typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints A-error-handling Area: Error handling labels Oct 15, 2021

rust-highfive assigned camelid Oct 15, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2021

jyn514 approved these changes Oct 15, 2021
View reviewed changes

camelid reviewed Oct 15, 2021
View reviewed changes

GuillaumeGomez force-pushed the correctly-emit-errors branch from 94ff696 to 8d9dbf7Compare October 15, 2021 19:37

camelid changed the title ~~Abort when error happens and not later on~~Remove FIXME since there is nothing to be fixedOct 16, 2021

camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2021

Remove FIXME since there is nothing to be fixed.
7bad85e
The errors are deduplicated when displayed to users. They only appear multiple times in UI tests.

GuillaumeGomez force-pushed the correctly-emit-errors branch from 8d9dbf7 to 7bad85eCompare October 16, 2021 20:15

GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2021

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 16, 2021

GuillaumeGomez force-pushed the correctly-emit-errors branch 2 times, most recently from 629ec2a to 7bad85eCompare October 16, 2021 20:33

GuillaumeGomez mentioned this pull request Oct 16, 2021
Rollup of 7 pull requests #89959
Closed

JohnTitor mentioned this pull request Oct 16, 2021
Rollup of 7 pull requests #89968
Merged

bors merged commit c393f33 into rust-lang:masterOct 17, 2021

rustbot added this to the 1.57.0 milestone Oct 17, 2021

GuillaumeGomez deleted the correctly-emit-errors branch October 17, 2021 10:41

- tcx.sess.abort_if_errors();
+// Avoid emitting duplicate errors later on.
+ tcx.sess.abort_if_errors();

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Oct 15, 2021• edited by camelid Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

camelid commented Oct 15, 2021

Uh oh!

GuillaumeGomez commented Oct 15, 2021

Uh oh!

Mark-Simulacrum commented Oct 15, 2021

Uh oh!

camelidOct 15, 2021

Choose a reason for hiding this comment

Uh oh!

camelidOct 15, 2021

Choose a reason for hiding this comment

Before

After

Uh oh!

GuillaumeGomezOct 15, 2021

Choose a reason for hiding this comment

Uh oh!

camelid commented Oct 15, 2021

Uh oh!

camelid commented Oct 15, 2021

Uh oh!

camelid commented Oct 15, 2021

Uh oh!

GuillaumeGomez commented Oct 15, 2021

Uh oh!

camelid commented Oct 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Oct 15, 2021

Uh oh!

GuillaumeGomez commented Oct 15, 2021

Uh oh!

camelid commented Oct 16, 2021

Uh oh!

GuillaumeGomez commented Oct 16, 2021

Uh oh!

camelid commented Oct 16, 2021

Uh oh!

bors commented Oct 16, 2021

Uh oh!

camelid commented Oct 16, 2021

Uh oh!

bors commented Oct 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GuillaumeGomez commented Oct 15, 2021•
edited by camelid
Loading

camelid commented Oct 15, 2021•
edited
Loading