Uh oh!
There was an error while loading. Please reload this page.
Merged
Conversation
rust-highfive
commented
Oct 16, 2021
Contributor
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
commented
Oct 16, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
nagisa
commented
Oct 16, 2021
Member
@bors r+ rollup Thanks! |
bors
commented
Oct 16, 2021
Collaborator
📌 Commit 2031aaf589c3f6bc1662e0b5a0615c1291486909 has been approved by |
matthiaskrgr
commented
Oct 16, 2021
Member
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nagisa
commented
Oct 17, 2021
Member
@bors r+ |
bors
commented
Oct 17, 2021
Collaborator
📌 Commit 3c1d554 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#89738 (ty::pretty: prevent infinite recursion for `extern crate` paths.) - rust-lang#89888 (Make `llvm.download-ci-llvm="if-available"` work for tier 2 targets with host tools) - rust-lang#89945 (Remove a mention to `copy_from_slice` from `clone_from_slice` doc) - rust-lang#89946 (Fix an ICE with TAITs and Future) - rust-lang#89963 (Some "parenthesis" and "parentheses" fixes) - rust-lang#89975 (Add a regression test for rust-lang#85921) - rust-lang#89977 (Make Result::as_mut const) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 21, 2021
…=nagisa Some "parenthesis" and "parentheses" fixes "Parenthesis" is the singular (e.g. one `(` or one `)`) and "parentheses" is the plural (multiple `(` or `)`s) and this is not hard to mix up so here are some fixes for that. Inspired by rust-lang#89958
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Parenthesis" is the singular (e.g. one
(or one)) and "parentheses" is the plural (multiple(or)s) and this is not hard to mix up so here are some fixes for that.Inspired by #89958