Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #90026
Closed
matthiaskrgr wants to merge 23 commits into
Closed
Conversation
This can append if within the same module a `#[macro_export] macro_rules!` is declared but also a reexport of itself producing two export of the same macro in the same module. In that case we only want to document it once.
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
HermitCore's kernel itself doesn't support TLS. Consequently, the entries in x86_64-unknown-none-hermitkernel should be removed. This commit should help to finalize rust-lang#89062.
No functional changes intended. The LLVM commit llvm/llvm-project@89b5706 moved TargetRegistry.(h|cpp) from Support to MC. This adapts RustWrapper accordingly.
The affected crates have had plenty of time to update. By keeping these as lints rather than making them hard errors, we ensure that downstream crates will still be able to compile, even if they transitive depend on broken versions of the affected crates. This should hopefully discourage anyone from writing any new code which relies on the backwards-compatibility behavior.
…esleywiser Make all proc-macro back-compat lints deny-by-default The affected crates have had plenty of time to update. By keeping these as lints rather than making them hard errors, we ensure that downstream crates will still be able to compile, even if they transitive depend on broken versions of the affected crates. This should hopefully discourage anyone from writing any new code which relies on the backwards-compatibility behavior.
… r=nagisa RustWrapper: adapt for an LLVM API change No functional changes intended. The LLVM commit llvm/llvm-project@89b5706 moved TargetRegistry.(h|cpp) from Support to MC. This adapts RustWrapper accordingly.
…laumeGomez
Fix macro_rules! duplication when reexported in the same module
This can append if within the same module a `#[macro_export] macro_rules!`
is declared but also a reexport of itself producing two export of the same
macro in the same module. In that case we only want to document it once.
Before:
```
Module {
is_crate: true,
items: [
Id("0:4"), // pub use crate::repro as repro2;
Id("0:3"), // macro_rules! repro
Id("0:3"), // duplicate, same as above
],
}
```
After:
```
Module {
is_crate: true,
items: [
Id("0:4"), // pub use crate::repro as repro2;
Id("0:3"), // macro_rules! repro
],
}
```
Fixesrust-lang#89852removing TLS support in x86_64-unknown-none-hermitkernel HermitCore's kernel itself doesn't support TLS. Consequently, the entries in x86_64-unknown-none-hermitkernel should be removed. This commit should help to finalize rust-lang#89062.
…match-names, r=estebank Suggest a case insensitive match name regardless of levenshtein distance Fixesrust-lang#86170 Currently, `find_best_match_for_name` only returns a case insensitive match name depending on a Levenshtein distance. It's a bit unfortunate that that hides some suggestions for typos like `Bar` -> `BAR`. That idea is from rust-lang#46347 (comment), but I think it still makes some sense to show a candidate when we find a case insensitive match name as it's more like a typo. Skipped the `candidate != lookup` check because the current (i.e, `levenshtein_match`) returns the exact same `Symbol` anyway but it doesn't seem to confuse anything on UI tests. r? `@estebank`
… r=JohnTitor Add test for issue rust-lang#84957 - `str.as_bytes()` in a `const` expression Hi, this PR adds a test for issue rust-lang#84957 . I'm quite new to rustc so let me know if there's anything else that needs doing 😄 Closesrust-lang#84957
…=lnicola ⬆️ rust-analyzer r? `@ghost`
Revert rust-lang#86011 to fix an incorrect bound check This reverts commit 36a1076, reversing changes made to e1e9319. Fixesrust-lang#89935 r? `@estebank`
matthiaskrgr
commented
Oct 18, 2021
MemberAuthor
@bors r+ rollup=never p=8 |
bors
commented
Oct 18, 2021
Collaborator
📌 Commit eccaca0 has been approved by |
matthiaskrgr
commented
Oct 18, 2021
MemberAuthor
some tests are failing locally already :| failures: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
str.as_bytes()in aconstexpression #89997 (Add test for issue Panic in compiler\rustc_mir\src\borrow_check\region_infer\mod.rs:2120:35 #84957 -str.as_bytes()in aconstexpression)Sizedpredicate to end of list #86011 to fix an incorrect bound check)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup