Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #90109
Closed
GuillaumeGomez wants to merge 26 commits into
Closed
Conversation
The way octal literals are written in IP addresses differs from the way they are written in Rust code, so the way that octal/hex literals in IPs are written is explictly mentioned.
Now that there can't be a bunch of leading zeros, parsing can be optimized a bit.
Co-authored-by: Cheng XU <3105373+xu-cheng@users.noreply.github.com>
I'm working on some LLVM patches in concert with a Rust patch, and it's helping me quite a bit to have this as an option. It doesn't seem that hard, so I figured I'd formalize it in x.py and send it upstream.
use array explicitly instead of vec for const content (even if optimizer smart enought to remove allocation)
…zer smart enought to remove allocation)
…d on foreign trait implementations
Reject octal zeros in IPv4 addresses This fixesrust-lang#86964 by rejecting octal zeros in IP addresses, such that `192.168.00.00000000` is rejected with a parse error, since having leading zeros in front of another zero indicates it is a zero written in octal notation, which is not allowed in the strict mode specified by RFC 6943 3.1.1. Octal rejection was implemented in rust-lang#83652, but due to the way it was implemented octal zeros were still allowed.
…in_overflow, r=m-ou-se Avoid overflow in `VecDeque::with_capacity_in()`. The overflow only happens if alloc is compiled with overflow checks enabled and the passed capacity is greater or equal 2^(usize::BITS-1). The overflow shadows the expected "capacity overflow" panic leading to a test failure if overflow checks are enabled for std in the CI. Unblocks [CI: Enable overflow checks for test (non-dist) builds rust-lang#89776](rust-lang#89776). For some reason the overflow is only observable with optimization turned off, but that is a separate issue.
…mulacrum config: add the option to enable LLVM tests I'm working on some LLVM patches in concert with a Rust patch, and it's helping me quite a bit to have this as an option. It doesn't seem that hard, so I figured I'd formalize it in x.py and send it upstream.
… r=jsha Add test for line-number setting The first commit updates the version of the package to be able to have multi-line commands (which looks much nicer for this test). r? ``@jsha``
Remove hir::map::blocks and use FnKind instead The principal tool is `FnLikeNode`, which is not often used and can be easily implemented using `rustc_hir::intravisit::FnKind`.
2229 migrations small cleanup This removes needless `format!`'ing of empty string and replaces `vec!` with const strings with const array.
…ntry-reexported-macro, r=notriddle Add test for duplicated sidebar entries for reexported macro Fixesrust-lang#90015. r? ``@notriddle``
…l-missing-doc-code-examples, r=jyn514 Add test to ensure that the missing_doc_code_examples is not triggered on foreign trait implementations Fixesrust-lang#76450. r? ``@jyn514``
…olnay Fix MIRI UB in `Vec::swap_remove` Fixesrust-lang#90055 I find it weird that `Vec::swap_remove` read the last element to the stack just to immediately put it back in the `Vec` in place of the one at index `index`. It seems much more natural to me to just read the element at position `index` and then move the last element in its place. I guess this might also slightly improve codegen.
GuillaumeGomez
commented
Oct 20, 2021
MemberAuthor
@bors: r+ p=9 rollup=never |
bors
commented
Oct 20, 2021
Collaborator
📌 Commit 0794293 has been approved by |
bors
commented
Oct 20, 2021
Collaborator
⌛ Testing commit 0794293 with merge 7e21ec3ad404efb5068e9d9327fc60cb2b5a6936... |
bors
commented
Oct 21, 2021
Collaborator
💥 Test timed out |
rust-log-analyzer
commented
Oct 21, 2021
Collaborator
GuillaumeGomez
commented
Oct 21, 2021
MemberAuthor
@bors retry |
hkratz
commented
Oct 21, 2021
Contributor
There is already a new rollup (#90119) currently in CI, so this one should probably be cancelled/closed. |
GuillaumeGomez
commented
Oct 21, 2021
MemberAuthor
Closing then! @bors: r- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
VecDeque::with_capacity_in(). #90010 (Avoid overflow inVecDeque::with_capacity_in().)Vec::swap_remove#90099 (Fix MIRI UB inVec::swap_remove)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup