Reduce use of LocalDefId <-> HirId maps

[cjgillot]

This is an attempt to reduce the perf effect of #89278.
r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 437652f1641a199a4822f756bf3ce86f7bbfea49 with merge ba6244813e20a79c9f865108e1add3078beb8799...

[bors]

☀️ Try build successful - checks-actions
Build commit: ba6244813e20a79c9f865108e1add3078beb8799 (ba6244813e20a79c9f865108e1add3078beb8799)

[rust-timer]

Queued ba6244813e20a79c9f865108e1add3078beb8799 with parent 45b600c, future comparison URL.

[rust-timer]

Finished benchmarking commit (ba6244813e20a79c9f865108e1add3078beb8799): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Large improvement in instruction counts (up to -2.3% on incr-patched: minor change builds of tokio-webpush-simple)
• Large regression in instruction counts (up to 2.7% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 6f4cc96 with merge 3c98d5fc58ff609ab72025df0586f8e61b4f96b1...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3c98d5fc58ff609ab72025df0586f8e61b4f96b1 (3c98d5fc58ff609ab72025df0586f8e61b4f96b1)

[rust-timer]

Queued 3c98d5fc58ff609ab72025df0586f8e61b4f96b1 with parent dd757b9, future comparison URL.

[rust-timer]

Finished benchmarking commit (3c98d5fc58ff609ab72025df0586f8e61b4f96b1): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Large improvement in instruction counts (up to -2.3% on incr-patched: minor change builds of tokio-webpush-simple)
• Large regression in instruction counts (up to 2.7% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[bors]

☔ The latest upstream changes (presumably #91230) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #90639) made this pull request unmergeable. Please resolve the merge conflicts.

[nagisa]

I'm happy to r=me this. Please rebase and squash the history a little before merging though.

[cjgillot]

@bors r=nagisa

[bors]

📌 Commit 8617ff0 has been approved by nagisa

[bors]

⌛ Testing commit 8617ff0 with merge f9d61cd...

[bors]

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing f9d61cd to master...

[rust-timer]

Finished benchmarking commit (f9d61cd): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

• Moderate improvement in instruction counts (up to -2.4% on incr-patched: minor change builds of tokio-webpush-simple)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression