Add `-Zassert-incr-state` to assert state of incremental cache by pierwill · Pull Request #90386 · rust-lang/rust

pierwill · 2021-10-28T20:34:04Z

Closes#85864.

rust-highfive · 2021-10-28T20:34:07Z

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill · 2021-10-28T20:38:06Z

r? @Aaron1011

pierwill · 2021-10-29T15:22:05Z

Having trouble figuring out what's causing this panic. x check runs successfully.

pierwill · 2021-11-09T17:04:01Z

@rustbot ready

Aaron1011 · 2021-11-17T22:20:38Z

Sorry for the delay in getting to this.

@bors r+

bors · 2021-11-17T22:20:39Z

📌 Commit 1642fdf has been approved by Aaron1011

…=Aaron1011 Add `-Zassert-incr-state` to assert state of incremental cache Closesrust-lang#85864.

Rollup of 8 pull requests Successful merges: - rust-lang#90386 (Add `-Zassert-incr-state` to assert state of incremental cache) - rust-lang#90438 (Clean up mess for --show-coverage documentation) - rust-lang#90480 (Mention `Vec::remove` in `Vec::swap_remove`'s docs) - rust-lang#90607 (Make slice->str conversion and related functions `const`) - rust-lang#90750 (rustdoc: Replace where-bounded Clean impl with simple function) - rust-lang#90895 (require full validity when determining the discriminant of a value) - rust-lang#90989 (Avoid suggesting literal formatting that turns into member access) - rust-lang#91002 (rustc: Remove `#[rustc_synthetic]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Use the normal arg-parsing machinery for `-Zassert-incr-state` The flag parser for `-Zassert-incr-state` currently extracts an `Option<String>`, and then performs an ad-hoc parsing step slightly later. From looking at rust-lang#90386, I can't see any reason why it doesn't just use the normal flag-parsing machinery. A second commit also extracts the underlying implementation to a separate helper function, so that it isn't cluttering up the main control flow. I found this while working on larger cleanups to incremental-file loading.

Rollup merge of #154450 - Zalathar:assert-incr-state, r=fmease Use the normal arg-parsing machinery for `-Zassert-incr-state` The flag parser for `-Zassert-incr-state` currently extracts an `Option<String>`, and then performs an ad-hoc parsing step slightly later. From looking at #90386, I can't see any reason why it doesn't just use the normal flag-parsing machinery. A second commit also extracts the underlying implementation to a separate helper function, so that it isn't cluttering up the main control flow. I found this while working on larger cleanups to incremental-file loading.

rust-highfive assigned oli-obk Oct 28, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2021

pierwill marked this pull request as draft October 28, 2021 20:34

rust-highfive assigned Aaron1011 and unassigned oli-obk Oct 28, 2021

This comment has been minimized.
Sign in to view

pierwill force-pushed the assert-incr-state-85864 branch from 9fa372f to 0388331Compare October 28, 2021 21:27

This comment has been minimized.
Sign in to view

Aaron1011 reviewed Oct 28, 2021
View reviewed changes

Comment threadcompiler/rustc_interface/src/tests.rs Outdated

Aaron1011 reviewed Oct 28, 2021
View reviewed changes

Comment threadcompiler/rustc_session/src/options.rs Outdated

Aaron1011 reviewed Oct 28, 2021
View reviewed changes

Comment threadcompiler/rustc_incremental/src/persist/load.rs Outdated

jyn514 reviewed Oct 29, 2021
View reviewed changes

Comment threadcompiler/rustc_incremental/src/persist/load.rs Outdated
Comment threadcompiler/rustc_session/src/config.rs Outdated

This comment has been minimized.
Sign in to view

pierwill force-pushed the assert-incr-state-85864 branch from 7e6a02d to 4679489Compare October 29, 2021 15:05

This comment has been minimized.
Sign in to view

pierwill changed the title ~~[WIP] Add -Zassert-incr-state to assert state of incremental cache~~[WIP] Add -Zassert-incr-state to assert state of incremental cacheOct 29, 2021

pierwill changed the title ~~[WIP] Add -Zassert-incr-state to assert state of incremental cache~~Add -Zassert-incr-state to assert state of incremental cacheOct 30, 2021

pierwill marked this pull request as ready for review October 30, 2021 15:24

Aaron1011 reviewed Oct 31, 2021
View reviewed changes

Comment threadcompiler/rustc_session/src/config.rs Outdated

Aaron1011 reviewed Oct 31, 2021
View reviewed changes

Comment threadcompiler/rustc_incremental/src/persist/load.rs Outdated

pierwill force-pushed the assert-incr-state-85864 branch from 88cd57c to 1684347Compare October 31, 2021 22:06

This comment has been minimized.
Sign in to view

Aaron1011 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2021

pierwill requested a review from Aaron1011 November 4, 2021 01:58

pierwill force-pushed the assert-incr-state-85864 branch 3 times, most recently from 15eaf5f to 0c8da93Compare November 8, 2021 19:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2021

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021

Add -Zassert-incr-state to assert state of incremental cache
1642fdf

pierwill force-pushed the assert-incr-state-85864 branch from 0c8da93 to 1642fdfCompare November 12, 2021 19:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2021

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
Rollup merge ofrust-lang#90386- pierwill:assert-incr-state-85864, r…
a4739f2
…=Aaron1011 Add `-Zassert-incr-state` to assert state of incremental cache Closesrust-lang#85864.

matthiaskrgr mentioned this pull request Nov 18, 2021
Rollup of 7 pull requests #91001
Closed

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
Rollup merge ofrust-lang#90386- pierwill:assert-incr-state-85864, r…
682a636
…=Aaron1011 Add `-Zassert-incr-state` to assert state of incremental cache Closesrust-lang#85864.

JohnTitor mentioned this pull request Nov 18, 2021
Rollup of 6 pull requests #91013
Closed

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
Rollup merge ofrust-lang#90386- pierwill:assert-incr-state-85864, r…
b8a9cd4
…=Aaron1011 Add `-Zassert-incr-state` to assert state of incremental cache Closesrust-lang#85864.

JohnTitor mentioned this pull request Nov 18, 2021
Rollup of 9 pull requests #91016
Closed

JohnTitor mentioned this pull request Nov 18, 2021
Rollup of 8 pull requests #91019
Merged

bors merged commit 728b3f2 into rust-lang:masterNov 18, 2021

rustbot added this to the 1.58.0 milestone Nov 18, 2021

Zalathar mentioned this pull request Mar 27, 2026
Use the normal arg-parsing machinery for -Zassert-incr-state#154450
Merged

Uh oh!

Uh oh!

Conversation

pierwill commented Oct 28, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Oct 28, 2021

Uh oh!

pierwill commented Oct 28, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pierwill commented Oct 29, 2021

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

pierwill commented Nov 9, 2021

Uh oh!

Aaron1011 commented Nov 17, 2021

Uh oh!

bors commented Nov 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pierwill commented Oct 28, 2021•
edited
Loading