Skip to content

Clarify what to do with accepted feature gates - #90472

Merged
bors merged 2 commits into
rust-lang:masterfrom
joshtriplett:clarify-feature-acceptance
Nov 3, 2021
Merged

Clarify what to do with accepted feature gates#90472
bors merged 2 commits into
rust-lang:masterfrom
joshtriplett:clarify-feature-acceptance

Conversation

@joshtriplett

Copy link
Copy Markdown
Member

The documentation only referenced removed.rs, but feature gates for
accepted features move to accepted.rs.

The documentation only referenced `removed.rs`, but feature gates for
accepted features move to `accepted.rs`.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2021
@jyn514

Copy link
Copy Markdown
Member

Could you also link to https://rustc-dev-guide.rust-lang.org/feature-gates.html#feature-gates at the same time?

@joshtriplett

Copy link
Copy Markdown
MemberAuthor

Done.

@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 2, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit eb23a73 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 2, 2021
…ance, r=jyn514
Clarify what to do with accepted feature gates
The documentation only referenced `removed.rs`, but feature gates for
accepted features move to `accepted.rs`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2021
…askrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#90084 (Make printed message match the code comment)
- rust-lang#90354 (Document clippy on nightly-rustc)
- rust-lang#90417 (stabilize `relaxed_struct_unsize`)
- rust-lang#90472 (Clarify what to do with accepted feature gates)
- rust-lang#90500 (Update Clippy dependencies)
- rust-lang#90502 (Split doc_cfg and doc_auto_cfg features)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bc26dbb into rust-lang:masterNov 3, 2021
@rustbotrustbot added this to the 1.58.0 milestone Nov 3, 2021
@joshtriplett
joshtriplett deleted the clarify-feature-acceptance branch November 3, 2021 13:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtriplett@rust-highfive@jyn514@bors@matthewjasper@rustbot