Skip to content

Switch to normalized triples for Fuchsia - #90510

Closed
petrhosek wants to merge 1 commit into
rust-lang:masterfrom
petrhosek:fuchsia-normalized
Closed

Switch to normalized triples for Fuchsia#90510
petrhosek wants to merge 1 commit into
rust-lang:masterfrom
petrhosek:fuchsia-normalized

Conversation

@petrhosek

@petrhosekpetrhosek commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

This is a revert of e950d22 which is no
longer needed since Clang now does normalization and handles all triple
spellings.

@rust-highfive

rust-highfive commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2021
@camelid

camelid commented Nov 2, 2021

Copy link
Copy Markdown
Member

@petrhosek There seem to be merge conflicts. I think you'll need to rebase over upstream/master.

@petrhosek
Switch to normalized triples for Fuchsia
8c5fcc7
This is a revert of e950d22 which is no
longer needed since Clang now does normalization and handles all triple
spellings.
tmandry
tmandry approved these changes Nov 4, 2021
View reviewed changes

@tmandrytmandry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings Fuchsia triple naming in line with nearly every other OS, so looks good to me.

@camelidcamelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 4, 2021
@emilyalbini

emilyalbini commented Nov 7, 2021

Copy link
Copy Markdown
Member

r? rust-lang/compiler

CI changes look good, but the compiler team should actually approve the change.

@tmandry

tmandry commented Nov 18, 2021

Copy link
Copy Markdown
Member

Re-rolling

r? rust-lang/compiler

@estebank

estebank commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 8c5fcc7 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 19, 2021
@matthiaskrgr
Rollup merge ofrust-lang#90510- petrhosek:fuchsia-normalized, r=est…
86568e5
…ebank
Switch to normalized triples for Fuchsia
This is a revert of e950d22 which is no
longer needed since Clang now does normalization and handles all triple
spellings.
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 19, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 19, 2021
@matthiaskrgr
Rollup merge ofrust-lang#90510- petrhosek:fuchsia-normalized, r=est…
f7238fa
…ebank
Switch to normalized triples for Fuchsia
This is a revert of e950d22 which is no
longer needed since Clang now does normalization and handles all triple
spellings.
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 19, 2021
Closed
@matthiaskrgr

matthiaskrgr commented Nov 19, 2021

Copy link
Copy Markdown
Member

Looks like this failed in a rollup: #91056 (comment)
@bors r- rollup=iffy

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 19, 2021
@JohnCSimon

JohnCSimon commented Dec 12, 2021

Copy link
Copy Markdown

Ping from triage:
@petrhosek Can you please post your status on this PR? Is it ready for review? Thank you.

@JohnCSimon

JohnCSimon commented Jan 30, 2022

Copy link
Copy Markdown

triage:
I'm moving this to waiting on Review... don't want to close a PR as inactive if it already has an approval - even though it hasn't moved for two months.

@rustbot label: -S-waiting-on-author +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2022
@pnkfelix

pnkfelix commented Feb 10, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@petrhosek@tmandry this seemed like it failed in rollup. Can you look into it? (And let us know if this needs a new owner.)

@pnkfelixpnkfelix added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2022
@JohnCSimon

JohnCSimon commented Mar 6, 2022

Copy link
Copy Markdown

@petrhosek
Ping from triage: I'm closing this due to inactivity. This hasn't been touched in months.
Please reopen when you are ready to continue with this.
Thanks for your contribution.

@rustbot label: +S-inactive

@rustbotrustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Mar 6, 2022
@djkoloskidjkoloski mentioned this pull request Jan 3, 2023
Merged
djkoloski added a commit to djkoloski/rust that referenced this pull request Jan 5, 2023
@djkoloski
Add vendor to Fuchsia's target triple
f6ef039
Historically, Rust's Fuchsia targets have been labeled x86_64-fuchsia
and aarch64-fuchsia. However, they should technically contain vendor
information. This CL changes Fuchsia's target triples to include the
"unknown" vendor since Clang now does normalization and handles all
triple spellings.
This was previously attempted in rust-lang#90510, which was closed due to
inactivity.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge ofrust-lang#106429- djkoloski:add_vendor_to_fuchsia_targ…
ce8fbe7
…et_triple, r=nagisa
Add vendor to Fuchsia's target triple
Historically, Rust's Fuchsia targets have been labeled x86_64-fuchsia and aarch64-fuchsia. However, they should technically contain vendor information. This CL changes Fuchsia's target triples to include the "unknown" vendor since Clang now does normalization and handles all triple spellings.
This was previously attempted in rust-lang#90510, which was closed due to inactivity.
@workingjubileeworkingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmandrytmandrytmandry approved these changes

Assignees

@estebankestebank

Labels

O-fuchsiaOperating system: FuchsiaS-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@petrhosek@rust-highfive@camelid@emilyalbini@tmandry@estebank@bors@matthiaskrgr@JohnCSimon@pnkfelix@jackh726@workingjubilee@rustbot