Skip to content

Warn for variables that are no longer captured - #90597

Merged
bors merged 4 commits into
rust-lang:masterfrom
nikomatsakis:issue-90465
Nov 6, 2021
Merged

Warn for variables that are no longer captured#90597
bors merged 4 commits into
rust-lang:masterfrom
nikomatsakis:issue-90465

Conversation

@nikomatsakis

@nikomatsakisnikomatsakis commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

r? @wesleywiser

cc @rust-lang/wg-rfc-2229

Fixes#90465

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2021
@nikomatsakisnikomatsakis mentioned this pull request Nov 5, 2021
Closed
@nikomatsakisnikomatsakis added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 5, 2021
@nikomatsakis

nikomatsakis commented Nov 5, 2021

Copy link
Copy Markdown
ContributorAuthor

Nominating for backport: this bug fixes incorrect migration that can cause subtle changes in execution order (see #90465)

arora-aman
arora-aman reviewed Nov 5, 2021
View reviewed changes

@arora-amanarora-aman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. I only have nits.

Comment threadcompiler/rustc_typeck/src/check/upvar.rs
Comment threadcompiler/rustc_typeck/src/check/upvar.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/upvar.rs
Comment threadcompiler/rustc_typeck/src/check/upvar.rs Outdated
mbartlett21
mbartlett21 reviewed Nov 5, 2021
View reviewed changes
Comment threadcompiler/rustc_typeck/src/check/upvar.rs Outdated
wesleywiser
wesleywiser approved these changes Nov 5, 2021
View reviewed changes

@wesleywiserwesleywiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, feel free to take it or leave it 🙂

r=me with CapturesInfo renamed per @arora-aman's suggestion

Comment threadcompiler/rustc_typeck/src/check/upvar.rs Outdated
@nikomatsakis

nikomatsakis commented Nov 5, 2021

Copy link
Copy Markdown
ContributorAuthor

@bors r=wesleywiser

@bors

bors commented Nov 5, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 4154e8a has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2021
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2021
@bors
Auto merge ofrust-lang#90631- matthiaskrgr:rollup-a5tzjh3, r=matthi…
d32993a
…askrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#89942 (Reorder `widening_impl`s to make the doc clearer)
- rust-lang#90569 (Fix tests using `only-i686` to use the correct `only-x86` directive)
- rust-lang#90597 (Warn for variables that are no longer captured)
- rust-lang#90623 (Remove more checks for LLVM < 12)
- rust-lang#90626 (Properly register text_direction_codepoint_in_comment lint.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4b1cb73 into rust-lang:masterNov 6, 2021
@rustbotrustbot added this to the 1.58.0 milestone Nov 6, 2021
@apirainoapiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021
@apiraino

apiraino commented Nov 11, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Beta backport approved as per compiler team on Zulip

stable backport declined

@rustbot label +beta-accepted
@rustbot label -stable-nominated

@rustbot

rustbot commented Nov 11, 2021

Copy link
Copy Markdown
Collaborator

Error: Label beta-accepted can only be set by Rust team members;we were unable to check if you are a team member.

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbotrustbot removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Nov 11, 2021
@apirainoapiraino added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 11, 2021
@cuvipercuviper mentioned this pull request Nov 16, 2021
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 16, 2021
@cuvipercuviper modified the milestones: 1.58.0, 1.57.0Nov 16, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2021
@bors
Auto merge ofrust-lang#90938- cuviper:beta-next, r=Mark-Simulacrum
7611e64
[beta] backports
- Fix assertion failures in OwnedHandle with windows_subsystem. rust-lang#88798
- Ensure that pushing empty path works as before on verbatim paths rust-lang#89665
- Feature gate + make must_not_suspend allow-by-default rust-lang#89826
- Only use clone3 when needed for pidfd rust-lang#89930
- Fix documentation header sizes rust-lang#90186
- Fixes incorrect handling of ADT's drop requirements rust-lang#90218
- Fix ICE when forgetting to Box a parameter to a Self::func call rust-lang#90221
- Prevent duplicate caller bounds candidates by exposing default substs in Unevaluated rust-lang#90266
- Update odht crate to 0.3.1 (big-endian bugfix) rust-lang#90403
- rustdoc: Go back to loading all external crates unconditionally rust-lang#90489
- Split doc_cfg and doc_auto_cfg features rust-lang#90502
- Apply adjustments for field expression even if inaccessible rust-lang#90508
- Warn for variables that are no longer captured rust-lang#90597
- Properly register text_direction_codepoint_in_comment lint. rust-lang#90626
- CI: Use ubuntu image to download openssl, curl sources, cacert.pem for x86 dist builds rust-lang#90457
- Android is not GNU rust-lang#90834
- Update llvm submodule rust-lang#90954
Additionally, this bumps the stage 0 compiler from beta to stable 1.56.1.
r? `@Mark-Simulacrum`
@matthiaskrgrmatthiaskrgr mentioned this pull request May 7, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes
+2 more reviewers
@arora-amanarora-amanarora-aman left review comments
@mbartlett21mbartlett21mbartlett21 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@wesleywiserwesleywiser

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

Missing warning for migration of let _ = x between Rust 2018 and 2021 edition

9 participants

@nikomatsakis@bors@apiraino@rustbot@wesleywiser@arora-aman@mbartlett21@cuviper@rust-highfive