Skip to content

more clippy fixes - #90668

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:clippy_nov7
Nov 7, 2021
Merged

more clippy fixes#90668
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:clippy_nov7

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Nov 7, 2021

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Nov 7, 2021

Copy link
Copy Markdown
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Nov 7, 2021

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2021
jyn514
jyn514 reviewed Nov 7, 2021
View reviewed changes
Comment threadcompiler/rustc_typeck/src/check/expr.rs Outdated
@jyn514

jyn514 commented Nov 7, 2021

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

r=me assuming perf isn't too bad :)

@rust-timer

rust-timer commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2021
@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 5f58acf7cc6c20f022c63b3917839954d81b7edd with merge a8cc143f16a2f039e5635ec664795b3954ac98df...

@jyn514jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2021
@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: a8cc143f16a2f039e5635ec664795b3954ac98df (a8cc143f16a2f039e5635ec664795b3954ac98df)

@rust-timer

rust-timer commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

Queued a8cc143f16a2f039e5635ec664795b3954ac98df with parent 90a273b, future comparison URL.

@rust-timer

rust-timer commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a8cc143f16a2f039e5635ec664795b3954ac98df): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2021
@matthiaskrgr

matthiaskrgr commented Nov 7, 2021

Copy link
Copy Markdown
MemberAuthor

removed the autoderef var.

@bors r=jyn514

@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 5c45455 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2021
@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5c45455 with merge d519729aacaf4e34857f73222a0227ac97b53626...

@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@rust-log-analyzer

rust-log-analyzer commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2021
@jyn514

jyn514 commented Nov 7, 2021

Copy link
Copy Markdown
Member

GitHub Actions has encountered an internal error when running your job.

🤦

@bors retry

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2021
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2021
@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5c45455 with merge 46b8e74...

@bors

bors commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 46b8e74 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2021
@bors
bors merged commit 46b8e74 into rust-lang:masterNov 7, 2021
@rustbotrustbot added this to the 1.58.0 milestone Nov 7, 2021
@borsbors mentioned this pull request Nov 7, 2021
Closed
@rust-timer

rust-timer commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (46b8e74): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@matthiaskrgr
matthiaskrgr deleted the clippy_nov7 branch January 25, 2025 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jackh726jackh726

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

8 participants

@matthiaskrgr@rust-highfive@jyn514@rust-timer@bors@rust-log-analyzer@jackh726@rustbot