Document non-guarantees for Hash by the8472 · Pull Request #90995 · rust-lang/rust

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 · 2021-11-18T01:05:43Z

Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of Hasher::write_usize uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.

Question

Should this go on the module level documentation instead since it also concerns Hasher to some extent and not just Hash?

resolves#74215

Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized.

rust-highfive · 2021-11-18T01:05:46Z

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

pierwill

This is great!

Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

nbdd0121 · 2021-11-24T00:18:47Z

A hasher that overrides all provided methods could provide a portable hash though, right? E.g. always use LE, and delegate write_[ui]size to write_[ui]64.

the8472 · 2021-11-24T09:36:43Z

That could cover some cases, but the Hash implementation itself could also be platform-dependent because the type itself is or perhaps because it turns a [usize; N] into &[u8] and pass that to the Hasher. So both Hash and Hasher need to be vetted for portability.

dtolnay

This looks great to me. Between here and the module docs, this is the place I would think to look first.

Thanks!

dtolnay · 2021-11-26T23:07:45Z

@bors r+ rollup

bors · 2021-11-26T23:07:47Z

📌 Commit 53fc69f has been approved by dtolnay

Document non-guarantees for Hash Dependence on endianness and type sizes was reported for enum discriminants in rust-lang#74215 but it is a more general issue since for example the default implementation of `Hasher::write_usize` uses native endianness. Additionally the implementations of library types are occasionally changed as their internal fields change or hashing gets optimized. ## Question Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`? resolvesrust-lang#74215

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#83791 (Weaken guarantee around advancing underlying iterators in zip) - rust-lang#90995 (Document non-guarantees for Hash) - rust-lang#91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support) - rust-lang#91062 (rustdoc: Consolidate static-file replacement mechanism) - rust-lang#91208 (Account for incorrect `where T::Assoc = Ty` bound) - rust-lang#91266 (Use non-generic inner function for pointer formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 18, 2021

rust-highfive assigned yaahc Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

pierwill reviewed Nov 18, 2021
View reviewed changes

Comment threadlibrary/core/src/hash/mod.rs Outdated
Comment threadlibrary/core/src/hash/mod.rs Outdated

Apply suggestions from code review
53fc69f
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>

dtolnay approved these changes Nov 26, 2021
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2021

dtolnay assigned dtolnay and unassigned yaahc Nov 26, 2021

This was referenced Nov 27, 2021
Rollup of 5 pull requests #91287
Closed
Rollup of 6 pull requests #91288
Merged

bors merged commit 43279b2 into rust-lang:masterNov 27, 2021

rustbot added this to the 1.59.0 milestone Nov 27, 2021

hanna-kruppe mentioned this pull request Jul 27, 2025
Hash portability between compiler versions is potentially misleading #144540
Open

Uh oh!

Uh oh!

Conversation

the8472 commented Nov 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Question

Uh oh!

rust-highfive commented Nov 18, 2021

Uh oh!

pierwill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nbdd0121 commented Nov 24, 2021

Uh oh!

the8472 commented Nov 24, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Nov 26, 2021

Uh oh!

bors commented Nov 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

the8472 commented Nov 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Question

Uh oh!

rust-highfive commented Nov 18, 2021

Uh oh!

pierwill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nbdd0121 commented Nov 24, 2021

Uh oh!

the8472 commented Nov 24, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Nov 26, 2021

Uh oh!

bors commented Nov 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

the8472 commented Nov 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Question

Uh oh!

rust-highfive commented Nov 18, 2021

Uh oh!

pierwill left a comment

Choose a reason for hiding this comment

Uh oh!

the8472 commented Nov 18, 2021•
edited
Loading

the8472 commented Nov 24, 2021•
edited
Loading

the8472 commented Nov 18, 2021•
edited
Loading

the8472 commented Nov 24, 2021•
edited
Loading

the8472 commented Nov 18, 2021•
edited
Loading

the8472 commented Nov 24, 2021•
edited
Loading

the8472 commented Nov 18, 2021•
edited
Loading

the8472 commented Nov 24, 2021•
edited
Loading