Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #91033
Merged
Merged
Conversation
`Candidate` enum has only a single `Ref` variant. Refactor it into a struct and reduce overall indentation of the code by two levels. No functional changes.
In some situations we should want on influence into the .cargo/config when we use vendored source. One example is rust-lang#90764, when we want to workaround some references to crates forked and living in git, that are missing in the vendor/ directory. This commit will create the .cargo/config file only when the .cargo/ directory needs to be created.
Because it's always `'tcx`. In fact, some of them use a mixture of passed-in `$tcx` and hard-coded `'tcx`, so no other lifetime would even work. This makes the code easier to read.
Also use `Default::default()` in one `TypedArena::default()`, for consistency with `DroplessArena::default()`.
Make char conversion functions unstably const The char conversion functions like `char::from_u32` do trivial computations and can easily be converted into const fns. Only smaller tricks are needed to avoid non-const standard library functions like `Result::ok` or `bool::then_some`. Tracking issue: rust-lang#89259
add const generics test cc rust-lang#89829 (comment) r? rust-lang/project-const-generics
Refactor single variant `Candidate` enum into a struct `Candidate` enum has only a single `Ref` variant. Refactor it into a struct and reduce overall indentation of the code by two levels. No functional changes.
…mulacrum bootstap: create .cargo/config only if not present In some situations we should want on influence into the .cargo/config when we use vendored source. One example is rust-lang#90764, when we want to workaround some references to crates forked and living in git, that are missing in the vendor/ directory. This commit will create the .cargo/config file only when the .cargo/ directory needs to be created.
windows: Return the "Not Found" error when a path is empty Fixesrust-lang#90940
Move some tests to more reasonable directories - 9.5 cc rust-lang#73494 r? `@petrochenkov`
…=nagisa Suggest removal of arguments for unit variant, not replacement
Arenas cleanup I was looking closely at the arenas code and here are some small improvement to readability.
JohnTitor
commented
Nov 19, 2021
MemberAuthor
@bors r+ p=8 rollup=never |
bors
commented
Nov 19, 2021
Collaborator
📌 Commit 1576a7c has been approved by |
bors
commented
Nov 19, 2021
Collaborator
bors
commented
Nov 19, 2021
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Nov 19, 2021
Collaborator
Finished benchmarking commit (e8423e6): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Candidateenum into a struct #90633 (Refactor single variantCandidateenum into a struct)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup