Skip to content

Turned all 0x1b_u8.into() into '\x1b' in the docs - #91040

Closed
mahmoud-moursy wants to merge 3 commits into
rust-lang:masterfrom
mahmoud-moursy:patch-2
Closed

Turned all 0x1b_u8.into() into '\x1b' in the docs#91040
mahmoud-moursy wants to merge 3 commits into
rust-lang:masterfrom
mahmoud-moursy:patch-2

Conversation

@mahmoud-moursy

Copy link
Copy Markdown
Contributor

Housekeeping to keep docs clean and up to date -- turned all instances of 0x1b_u8.into() into \x1b when I stumbled upon this in the Rust docs.

Tested these changes using this code:

fnmain(){let esc:char = 0x1b_u8.into();let esc_2 = '\x1b';assert_eq!(esc, esc_2);}

It exited and returned code 0.

Housekeeping to keep docs clean and up to date.
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2021
Comment threadlibrary/core/src/char/methods.rs Outdated
@ghost

ghost commented Nov 19, 2021

Copy link
Copy Markdown

There seem to be more occurrences in https://github.com/rust-lang/rust/blob/master/library/core/src/num/mod.rs like for example:

/// let lf = b'\n';/// let esc = 0x1b_u8;///

Do you want to turn those into b'\x1b'?

They are unnecessary as of Rust 2021
Co-authored-by: r00ster <r00ster91@protonmail.com>
@mahmoud-moursy

Copy link
Copy Markdown
ContributorAuthor

Do you want to turn those into b'\x1b'?

I would love to, but traversing the entirety of Rust's source code to find these instances would take me a lot of time.

@ghostghost mentioned this pull request Nov 19, 2021
@ghost

Copy link
Copy Markdown

@T-O-R-U-S there are actually not that many. Here's what I meant: #91044

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 19, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 19, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 19, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 20, 2021
@bors

bors commented Nov 20, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #91064) made this pull request unmergeable. Please resolve the merge conflicts.

@apirainoapiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 22, 2021
@m-ou-se

Copy link
Copy Markdown
Member

Closing this, since #91044 has already been merged.

@m-ou-sem-ou-se closed this Nov 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mahmoud-moursy@rust-highfive@bors@m-ou-se@apiraino