Skip to content

[beta] [1.57] Disable LLVM newPM by default - #91189

Closed
nagisa wants to merge 1 commit into
rust-lang:betafrom
nagisa:nagisa/beta-disable-newpm
Closed

[beta] [1.57] Disable LLVM newPM by default#91189
nagisa wants to merge 1 commit into
rust-lang:betafrom
nagisa:nagisa/beta-disable-newpm

Conversation

@nagisa

@nagisanagisa commented Nov 24, 2021

Copy link
Copy Markdown
Member

This is a temporary solution until we manage to get some sort of a workaround for the rampant inlining behaviour and other issues such as #91128 in place. Expect significant compilation time regressions in other areas, though.

@nagisanagisa added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Nov 24, 2021
@nagisa
nagisa requested review from nikic and pnkfelixNovember 24, 2021 19:16
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2021
@nagisa

Copy link
Copy Markdown
MemberAuthor

I went ahead and unilaterally specified the beta-accepted tag based on conversation from here onwards.

@rust-log-analyzer

This comment has been minimized.

@camelid

Copy link
Copy Markdown
Member

(Just noting it might be helpful to add some explanation of why this change is being made to the PR description.)

@camelidcamelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 24, 2021
@nagisa
nagisaforce-pushed the nagisa/beta-disable-newpm branch from d31a65a to 5026492CompareNovember 24, 2021 19:27
@camelid

Copy link
Copy Markdown
Member

Thanks for the description ❤️

Expect significant compilation time regressions in other areas, though.

@bors rollup=never

@camelidcamelid added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Nov 24, 2021
@nagisa

Copy link
Copy Markdown
MemberAuthor

One pretty concerning thing I just realised now is that we pretty much had almost no testing of LLVM 13.0 with the oldPM, unless people were really heavily using the -Z flag to disable newPM, which I doubt they did.

@camelid

Copy link
Copy Markdown
Member

I went ahead and unilaterally specified the beta-accepted tag based on conversation from here onwards.

This PR is filed against beta and marked as beta-accepted. Usually, one would just open a PR against master (#91190) and mark that as beta-accepted. Then someone from the release team will backport it.

@nikic

Copy link
Copy Markdown
Contributor

One pretty concerning thing I just realised now is that we pretty much had almost no testing of LLVM 13.0 with the oldPM, unless people were really heavily using the -Z flag to disable newPM, which I doubt they did.

I believe the LLVM 13 upgrade landed in 1.56 already, so it was tested in that release cycle. Though you're right that 1.57 did not receive any testing with the legacy PM.

@nagisanagisa mentioned this pull request Nov 24, 2021
@Mark-SimulacrumMark-Simulacrum changed the title [1.57] Disable LLVM newPM by default[beta] [1.57] Disable LLVM newPM by defaultNov 26, 2021
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Nov 26, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2021
…ulacrum
[beta] backports
* relate lifetime in TypeOutlives bounds on drop impls rust-lang#90840
* [beta] [1.57] Disable LLVM newPM by default rust-lang#91189
r? `@Mark-Simulacrum`
@nikic

Copy link
Copy Markdown
Contributor

This has been landed in #91263.

@nikicnikic closed this Nov 28, 2021
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nagisa@rust-highfive@rust-log-analyzer@camelid@nikic@wesleywiser@Mark-Simulacrum