Uh oh!
There was an error while loading. Please reload this page.
[beta] [1.57] Disable LLVM newPM by default - #91189
Conversation
rust-highfive
commented
Nov 24, 2021
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Nov 24, 2021
|
nagisa
commented
Nov 24, 2021
I went ahead and unilaterally specified the |
This comment has been minimized.
This comment has been minimized.
camelid
commented
Nov 24, 2021
(Just noting it might be helpful to add some explanation of why this change is being made to the PR description.) |
d31a65a to
5026492Comparecamelid
commented
Nov 24, 2021
Thanks for the description ❤️
@bors rollup=never |
nagisa
commented
Nov 24, 2021
One pretty concerning thing I just realised now is that we pretty much had almost no testing of LLVM 13.0 with the oldPM, unless people were really heavily using the |
camelid
commented
Nov 24, 2021
This PR is filed against beta and marked as beta-accepted. Usually, one would just open a PR against master (#91190) and mark that as beta-accepted. Then someone from the release team will backport it. |
nikic
commented
Nov 24, 2021
I believe the LLVM 13 upgrade landed in 1.56 already, so it was tested in that release cycle. Though you're right that 1.57 did not receive any testing with the legacy PM. |
…ulacrum [beta] backports * relate lifetime in TypeOutlives bounds on drop impls rust-lang#90840 * [beta] [1.57] Disable LLVM newPM by default rust-lang#91189 r? `@Mark-Simulacrum`
nikic
commented
Nov 28, 2021
This has been landed in #91263. |
This is a temporary solution until we manage to get some sort of a workaround for the rampant inlining behaviour and other issues such as #91128 in place. Expect significant compilation time regressions in other areas, though.