Lint elided lifetimes in path during lifetime resolution -- variant

[cjgillot]

Variant for #90446

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit e6f5068 with merge 3a16e8d1317082cc536140a5e6f2b312a196a417...

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions := True
configure: dist.missing-tools := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: configure: run `python /checkout/x.py --help`
configure: ---
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/compiler/rustc_resolve/src/late/lifetimes.rs at line 3282:
))
.emit();
}
- hir::LifetimeName::Param(_)
- | hir::LifetimeName::Implicit(_) => {
+ hir::LifetimeName::Param(_) | hir::LifetimeName::Implicit(_) => {
self.resolve_lifetime_ref(lt);
}
hir::LifetimeName::ImplicitObjectLifetimeDefault => {
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_ast_lowering/src/item.rs" "/checkout/compiler/rustc_driver/src/args.rs" "/checkout/compiler/rustc_traits/src/type_op.rs" "/checkout/compiler/rustc_driver/src/pretty.rs" "/checkout/compiler/rustc_traits/src/lib.rs" "/checkout/compiler/rustc_driver/src/lib.rs" "/checkout/compiler/rustc_traits/src/implied_outlives_bounds.rs" "/checkout/compiler/rustc_resolve/src/late/lifetimes.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.

[bors]

☀️ Try build successful - checks-actions
Build commit: 3a16e8d1317082cc536140a5e6f2b312a196a417 (3a16e8d1317082cc536140a5e6f2b312a196a417)

[rust-timer]

Queued 3a16e8d1317082cc536140a5e6f2b312a196a417 with parent 6d246f0, future comparison URL.

[rust-timer]

Finished benchmarking commit (3a16e8d1317082cc536140a5e6f2b312a196a417): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Large improvement in instruction counts (up to -3.9% on incr-unchanged builds of deep-vector)
• Moderate regression in instruction counts (up to 1.4% on incr-unchanged builds of wg-grammar)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[jackh726]

r? @jackh726

see #90446 (comment)