Uh oh!
There was an error while loading. Please reload this page.
Generalize "remove &" and "add *" suggestions to more than one deref - #91545
Merged
bors merged 1 commit intoMar 1, 2022
Merged
Conversation
compiler-errorsforce-pushed
the
deref-suggestion-improvements
branch
from
December 6, 2021 02:38
d494432 to
c432afeComparecamelid
reviewed
Jan 10, 2022
Uh oh!
There was an error while loading. Please reload this page.
bors
commented
Jan 14, 2022
Collaborator
☔ The latest upstream changes (presumably #92883) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errorsforce-pushed
the
deref-suggestion-improvements
branch
from
January 15, 2022 04:30
c432afe to
f9be623CompareJohnCSimon
commented
Feb 27, 2022
Ping from triage: |
compiler-errors
commented
Feb 27, 2022
ContributorAuthor
@JohnCSimon given that this has gone almost 3 months without review, I apologize for not keeping up with rebasing this every time bors tells me that it newly fails to merge. Should I re-roll for a new highfive reviewer, or @estebank do you plan on taking a look at this sometime in the near future? Thanks! |
compiler-errors
commented
Feb 27, 2022
ContributorAuthor
I will rebase this again, just for good measure. |
compiler-errorsforce-pushed
the
deref-suggestion-improvements
branch
from
February 27, 2022 23:31
f9be623 to
d1647f4Comparecompiler-errorsforce-pushed
the
deref-suggestion-improvements
branch
from
February 28, 2022 00:20
d1647f4 to
5ce3f56Comparejackh726
commented
Feb 28, 2022
Member
r? @jackh726 |
estebank
commented
Feb 28, 2022
Contributor
@bors r+ |
bors
commented
Feb 28, 2022
Collaborator
📌 Commit 5ce3f56 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#91545 (Generalize "remove `&`" and "add `*`" suggestions to more than one deref) - rust-lang#93385 (Rustdoc ty consistency fixes) - rust-lang#93926 (Lint against more useless `#[must_use]` attributes) - rust-lang#94094 (use BOOL for TCP_NODELAY setsockopt value on Windows) - rust-lang#94384 (Add Atomic*::from_mut_slice) - rust-lang#94448 (5 - Make more use of `let_chains`) - rust-lang#94452 (Sync portable-simd for bitmasks &c.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest removing more than one
&and&mut, along with suggesting adding more than one*(or a combination of the two).r? @estebank
(since you're experienced with these types of suggestions, feel free to reassign)