Implement additional split_inclusive variants for slices

[Jules-Bertholet]

Implements additional variants of the split iterator methods for strings and slices.

Methods implemented:

• slice::{r}split{n}{left}_inclusive{_mut}(), str::{r}split{n}{left}_inclusive(), and str::split_once{_left}_inclusive: The inclusive variants include the separator at the end of the returned elements, while the left_inclusive variants include it at the beginning.
• str::{r}split_initiator, and str::{r}split_ends: Variants of split_terminator that skip empty subslices at the beginning of the string, and at both ends of the string respectively.

In addition, this PR implements Clone when appropriate for the splitn iterators, and changes the return value of size_hint in a few cases.

Unresolved questions

This adds a lot of new methods because of all the possible permutations. The implementations are unified via macros, but it's a lot of choices to sort through in the documentation. Maybe some variants should be omitted, or a more generic interface should be provided?

One possibility to limit the combinatorial explosion, which I'm currently implementing, is to not have the additional "n" variant methods be defined directly on str/slice, but on their base iterator.

---

Interacts with #77998 (I haven't yet implemented as_str for all the new iterators)

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

Please see the contribution instructions for more information.

[Jules-Bertholet]

@scottmcm This is complete and ready for review!

[bors]

☔ The latest upstream changes (presumably #92556) made this pull request unmergeable. Please resolve the merge conflicts.

[scottmcm]

(Sorry for not responding over winter break)

Hmm, have you had any libs team feedback on all these? This is a great many new iterator types, for example, as you mentioned.

If not, maybe start a zulip thread to collect some thoughts?

[Jules-Bertholet]

@scottmcm The final form of this PR is a lot more extensive than I initially intended; I set out to add a single "obviously" missing iterator, but then realized there were many other "obvious" additions to be made. I'll make a thread on Zulip

[bors]

☔ The latest upstream changes (presumably #92598) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #95274) made this pull request unmergeable. Please resolve the merge conflicts.

[JohnCSimon]

ping from triage:
@Jules-Bertholet - can you please post the status of this PR?

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

[Jules-Bertholet]

This PR isn't ready as is, I need to integrate some libs team comments.

[Dylan-DPC]

@Jules-Bertholet any updates on this

[Jules-Bertholet]

@Dylan-DPC Not at present. I'm planning to make an API change proposal before continuing to work on the implementation, that should be ready soon

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-log-analyzer]

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

 --> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:726:1
|
726 | / iter_n! {
727 | | #[stable(feature = "rust1", since = "1.0.0")]
728 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
729 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
747 | | fn max_items;
748 | | }
| |_- in this macro invocation
|
|
= note: `-D missing-docs` implied by `-D warnings`
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |__- in this expansion of `iter_n!`
| |__- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:750:1
|
750 | / iter_n! {
751 | | #[stable(feature = "rust1", since = "1.0.0")]
752 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
753 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
772 | | fn max_items;
773 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:775:1
|
775 | / iter_n! {
776 | | #[stable(feature = "rust1", since = "1.0.0")]
777 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
778 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
796 | | fn max_items;
797 | | }
| |__- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:799:1
|
799 | / iter_n! {
800 | | #[stable(feature = "rust1", since = "1.0.0")]
801 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
802 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
821 | | fn max_items;
822 | | }
| |__- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:824:1
|
824 | / iter_n! {
825 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
826 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
827 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
848 | | fn max_items;
849 | | }
| |__- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:851:1
|
851 | / iter_n! {
852 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
853 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
854 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
875 | | fn max_items;
876 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:878:1
|
878 | / iter_n! {
879 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
880 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
881 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
902 | | fn max_items;
903 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:905:1
|
905 | / iter_n! {
906 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
907 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
908 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
929 | | fn max_items;
930 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:932:1
|
932 | / iter_n! {
933 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
934 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
935 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
956 | | fn max_items;
957 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:959:1
|
959 | / iter_n! {
960 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
961 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
962 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
983 | | fn max_items;
984 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:986:1
|
986 | / iter_n! {
987 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
988 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
989 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
1010 | | fn max_items;
1011 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/slice/iter/macros.rs:823:13
|
751 | / macro_rules! iter_n {
752 | | (
753 | | #[$stability:meta]
754 | | #[fused($fused_stability:meta)]
... |
823 | | pub fn max_items(self, n: usize) -> $iter_n<'a, T, P> {
... |
827 | | };
828 | | }
| |_- in this expansion of `iter_n!`
| |_- in this expansion of `iter_n!`
|
::: library/core/src/slice/iter.rs:1013:1
|
1013 | / iter_n! {
1014 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1015 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1016 | | #[must_use = "iterators are lazy and do nothing unless consumed"]
1037 | | fn max_items;
1038 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:849:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
849 | | pub fn as_str(&self) -> &'a str {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1013 | / generate_n_iterators! {
1014 | | forward:
1015 | | #[stable(feature = "rust1", since = "1.0.0")]
1016 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
1040 | | fn as_str;
1041 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:857:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
857 | | pub fn max_items(self, n: usize) -> $forward_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1013 | / generate_n_iterators! {
1014 | | forward:
1015 | | #[stable(feature = "rust1", since = "1.0.0")]
1016 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
1040 | | fn as_str;
1041 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:927:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
927 | | pub fn as_str(&self) -> &'a str {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1013 | / generate_n_iterators! {
1014 | | forward:
1015 | | #[stable(feature = "rust1", since = "1.0.0")]
1016 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
1040 | | fn as_str;
1041 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:939:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
939 | | pub fn max_items(self, n: usize) -> $reverse_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1013 | / generate_n_iterators! {
1014 | | forward:
1015 | | #[stable(feature = "rust1", since = "1.0.0")]
1016 | | #[fused(stable(feature = "fused", since = "1.26.0"))]
1040 | | fn as_str;
1041 | | }
| |_- in this macro invocation
---
423 | | {
424 | | // Forward iterator
425 | | forward:
... |
533 | | pub fn as_str(&self) -> &'a str {
... |
589 | | } => {}
590 | | }
| |_- in this expansion of `generate_pattern_iterators!`
| |_- in this expansion of `generate_pattern_iterators!`
...
1051 | / generate_pattern_iterators! {
1052 | | forward:
1053 | | #[stable(feature = "split_inclusive", since = "1.51.0")]
1054 | | #[fused(stable(feature = "split_inclusive", since = "1.51.0"))]
1089 | | delegate double ended;
1090 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:849:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
849 | | pub fn as_str(&self) -> &'a str {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1092 | / generate_n_iterators! {
1093 | | forward:
1094 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1095 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1119 | | fn as_str;
1120 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:857:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
857 | | pub fn max_items(self, n: usize) -> $forward_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1092 | / generate_n_iterators! {
1093 | | forward:
1094 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1095 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1119 | | fn as_str;
1120 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:927:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
927 | | pub fn as_str(&self) -> &'a str {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1092 | / generate_n_iterators! {
1093 | | forward:
1094 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1095 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1119 | | fn as_str;
1120 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:939:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
939 | | pub fn max_items(self, n: usize) -> $reverse_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1092 | / generate_n_iterators! {
1093 | | forward:
1094 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1095 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1119 | | fn as_str;
1120 | | }
| |_- in this macro invocation
---
423 | | {
424 | | // Forward iterator
425 | | forward:
... |
533 | | pub fn as_str(&self) -> &'a str {
... |
589 | | } => {}
590 | | }
| |_- in this expansion of `generate_pattern_iterators!`
| |_- in this expansion of `generate_pattern_iterators!`
...
1130 | / generate_pattern_iterators! {
1131 | | forward:
1132 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1133 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1169 | | delegate double ended;
1170 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:849:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
849 | | pub fn as_str(&self) -> &'a str {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1172 | / generate_n_iterators! {
1173 | | forward:
1174 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1175 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1199 | | fn as_str;
1200 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:857:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
857 | | pub fn max_items(self, n: usize) -> $forward_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1172 | / generate_n_iterators! {
1173 | | forward:
1174 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1175 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1199 | | fn as_str;
1200 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:927:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
927 | | pub fn as_str(&self) -> &'a str {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1172 | / generate_n_iterators! {
1173 | | forward:
1174 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1175 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1199 | | fn as_str;
1200 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:939:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
939 | | pub fn max_items(self, n: usize) -> $reverse_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1172 | / generate_n_iterators! {
1173 | | forward:
1174 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1175 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1199 | | fn as_str;
1200 | | }
| |_- in this macro invocation
---
423 | | {
424 | | // Forward iterator
425 | | forward:
... |
484 | | pub fn as_str(&self) -> &'a str {
... |
589 | | } => {}
590 | | }
| |_- in this expansion of `generate_pattern_iterators!`
| |_- in this expansion of `generate_pattern_iterators!`
...
1210 | / generate_pattern_iterators! {
1211 | | forward:
1212 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1213 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1235 | | delegate double ended;
1236 | | }
| |_- in this macro invocation
---
423 | | {
424 | | // Forward iterator
425 | | forward:
... |
533 | | pub fn as_str(&self) -> &'a str {
... |
589 | | } => {}
590 | | }
| |_- in this expansion of `generate_pattern_iterators!`
| |_- in this expansion of `generate_pattern_iterators!`
...
1210 | / generate_pattern_iterators! {
1211 | | forward:
1212 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1213 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1235 | | delegate double ended;
1236 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:857:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
857 | | pub fn max_items(self, n: usize) -> $forward_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1238 | / generate_n_iterators! {
1239 | | forward:
1240 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1241 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1259 | | fn as_str;
1260 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:939:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
939 | | pub fn max_items(self, n: usize) -> $reverse_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1238 | / generate_n_iterators! {
1239 | | forward:
1240 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1241 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1259 | | fn as_str;
1260 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:857:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
857 | | pub fn max_items(self, n: usize) -> $forward_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1324 | / generate_n_iterators! {
1325 | | forward:
1326 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1327 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1345 | | fn as_str;
1346 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:939:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
939 | | pub fn max_items(self, n: usize) -> $reverse_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1324 | / generate_n_iterators! {
1325 | | forward:
1326 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1327 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1345 | | fn as_str;
1346 | | }
| |_- in this macro invocation
---
423 | | {
424 | | // Forward iterator
425 | | forward:
... |
484 | | pub fn as_str(&self) -> &'a str {
... |
589 | | } => {}
590 | | }
| |_- in this expansion of `generate_pattern_iterators!`
| |_- in this expansion of `generate_pattern_iterators!`
...
1357 | / generate_pattern_iterators! {
1358 | | forward:
1359 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1360 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1382 | | delegate double ended;
1383 | | }
| |_- in this macro invocation
---
423 | | {
424 | | // Forward iterator
425 | | forward:
... |
533 | | pub fn as_str(&self) -> &'a str {
... |
589 | | } => {}
590 | | }
| |_- in this expansion of `generate_pattern_iterators!`
| |_- in this expansion of `generate_pattern_iterators!`
...
1357 | / generate_pattern_iterators! {
1358 | | forward:
1359 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1360 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1382 | | delegate double ended;
1383 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:857:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
857 | | pub fn max_items(self, n: usize) -> $forward_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1385 | / generate_n_iterators! {
1386 | | forward:
1387 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1388 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1406 | | fn as_str;
1407 | | }
| |_- in this macro invocation
error: missing documentation for an associated function
--> library/core/src/str/iter.rs:939:13
|
771 | / macro_rules! generate_n_iterators {
772 | | (
773 | | forward:
774 | | #[$forward_stability_attribute:meta]
... |
939 | | pub fn max_items(self, n: usize) -> $reverse_n_iterator<'a, P> {
... |
949 | | }
950 | | }
950 | | }
| |_- in this expansion of `generate_n_iterators!`
...
1385 | / generate_n_iterators! {
1386 | | forward:
1387 | | #[unstable(feature = "split_inclusive_variants", issue = "none")]
1388 | | #[fused(unstable(feature = "split_inclusive_variants", issue = "none"))]
1406 | | fn as_str;
1407 | | }
| |_- in this macro invocation

[bors]

☔ The latest upstream changes (presumably #99223) made this pull request unmergeable. Please resolve the merge conflicts.

[pitaj]

I've implemented an alternate API using combinators. It's available in the str_splitter crate. May be useful if you need something like rsplit_inclusive.

[Dylan-DPC]

Closing this as it is a draft and is inactive for some time. Feel free to reöpen this or create a new pr if you want to continue with this. Thanks