Add MemTagSanitizer Support by ivanloz · Pull Request #91675 · rust-lang/rust

ivanloz · 2021-12-08T21:34:12Z

Add support for the LLVM MemTagSanitizer.

On hardware which supports it (see caveats below), the MemTagSanitizer can catch bugs similar to AddressSanitizer and HardwareAddressSanitizer, but with lower overhead.

On a tag mismatch, a SIGSEGV is signaled with code SEGV_MTESERR / SEGV_MTEAERR.

Usage

-Zsanitizer=memtag -C target-feature="+mte"

Comments/Caveats

MemTagSanitizer is only supported on AArch64 targets with hardware support
Requires -C target-feature="+mte"
LLVM MemTagSanitizer currently only performs stack tagging.

TODO

Tests
Example

rust-highfive · 2021-12-08T21:34:15Z

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2021-12-08T21:34:16Z

⚠️Warning⚠️

These commits modify compiler targets. (See the Target Tier Policy.)

ivanloz · 2021-12-09T21:05:04Z

Added a basic test which checks that the attribute is being emitted as expected.

davidtwco

This looks reasonable to me but it's not an area that I'm familiar with.

davidtwco · 2021-12-13T13:13:59Z

r? @nagisa

tmiasko · 2021-12-13T21:47:32Z

MemTagSanitizer requires hardware support and the mte target feature.

Could we diagnose the attempt to use the sanitizer without mte target feature? This seems like the first issue one would generally encounter when trying to use the sanitizer.

FWIW the implementation looks good to me.

ivanloz · 2021-12-14T17:50:48Z

Tested passing the sanitizer without the mte target feature, and LLVM throws out a pretty difficult to understand error.

So I've gone ahead and added a check such that rustc errors out if the sanitizer is used without the target feature and emits a useful error message indicating the mte target feature is required.

JohnCSimon · 2022-01-23T01:09:06Z

Ping from triage:
@ivanloz can you please address the comments from @nagisa?

ivanloz · 2022-01-24T14:29:45Z

Apologies and thanks for your patience, this has been on my radar. I expect to have time to address the comments this week.

nagisa · 2022-02-11T23:51:03Z

r=me with or without the nit fixed.

bors · 2022-02-13T03:00:55Z

☔ The latest upstream changes (presumably #93670) made this pull request unmergeable. Please resolve the merge conflicts.

ivanloz · 2022-02-15T17:11:39Z

Merge conflicts should be resolved now.

nagisa · 2022-02-15T20:09:50Z

@bors r+

bors · 2022-02-15T20:09:51Z

📌 Commit da23682322ec6183f6968068ac2a99565c60abd8 has been approved by nagisa

bors · 2022-02-16T02:38:44Z

⌛ Testing commit da23682322ec6183f6968068ac2a99565c60abd8 with merge a08fcc4c75532ca5b4a508d561c9fe753e31333d...

bors · 2022-02-16T03:02:57Z

💔 Test failed - checks-actions

Adds support for the LLVM MemTagSanitizer.

ivanloz · 2022-02-16T15:28:54Z

I removed the quotes from the test's 'target-features' arg -- seems like that may have been causing the testing infrastructure to fail.

nagisa · 2022-02-16T15:50:40Z

@bors r+

bors · 2022-02-16T15:50:42Z

📌 Commit 568aeda has been approved by nagisa

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#89892 (Suggest `impl Trait` return type when incorrectly using a generic return type) - rust-lang#91675 (Add MemTagSanitizer Support) - rust-lang#92806 (Add more information to `impl Trait` error) - rust-lang#93497 (Pass `--test` flag through rustdoc to rustc so `#[test]` functions can be scraped) - rust-lang#93814 (mips64-openwrt-linux-musl: correct soft-foat) - rust-lang#93847 (kmc-solid: Use the filesystem thread-safety wrapper) - rust-lang#93877 (asm: Allow the use of r8-r14 as clobbers on Thumb1) - rust-lang#93892 (Only mark projection as ambiguous if GAT substs are constrained) - rust-lang#93915 (Implement --check-cfg option (RFC 3013), take 2) - rust-lang#93953 (Add the `known-bug` test directive, use it, and do some cleanup) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned davidtwco Dec 8, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2021

This comment has been minimized.
Sign in to view

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 9, 2021

ivanloz marked this pull request as draft December 9, 2021 14:45

ivanloz force-pushed the memtagsan branch from d07d2de to 910071dCompare December 9, 2021 16:45

tmiasko reviewed Dec 9, 2021
View reviewed changes

Comment threadcompiler/rustc_codegen_llvm/src/llvm/ffi.rs Outdated

ivanloz force-pushed the memtagsan branch 2 times, most recently from 77bd3d1 to 9b15ee4Compare December 9, 2021 21:02

ivanloz marked this pull request as ready for review December 9, 2021 21:05

davidtwco approved these changes Dec 13, 2021
View reviewed changes

rust-highfive assigned nagisa and unassigned davidtwco Dec 13, 2021

ivanloz force-pushed the memtagsan branch from 9b15ee4 to 749017bCompare December 14, 2021 17:47

nagisa reviewed Dec 18, 2021
View reviewed changes

Comment threadcompiler/rustc_session/src/session.rs Outdated

nagisa reviewed Dec 18, 2021
View reviewed changes

Comment threadsrc/tools/compiletest/src/header.rs Outdated

nagisa reviewed Dec 18, 2021
View reviewed changes

Comment threadsrc/test/codegen/sanitizer_memtag_attr_check.rs Outdated

nagisa added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021

ivanloz force-pushed the memtagsan branch from 749017b to 38635c7Compare February 9, 2022 18:55

nagisa reviewed Feb 11, 2022
View reviewed changes

Comment threadcompiler/rustc_codegen_llvm/src/attributes.rs Outdated
Comment threadsrc/tools/compiletest/src/header.rs Outdated

ivanloz force-pushed the memtagsan branch from 38635c7 to da23682Compare February 15, 2022 17:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2022

This comment has been minimized.
Sign in to view

MemTagSanitizer Support
568aeda
Adds support for the LLVM MemTagSanitizer.

ivanloz force-pushed the memtagsan branch from da23682 to 568aedaCompare February 16, 2022 14:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2022

matthiaskrgr mentioned this pull request Feb 18, 2022
Rollup of 10 pull requests #94134
Merged

bors merged commit 0bb72a2 into rust-lang:masterFeb 19, 2022

rustbot added this to the 1.60.0 milestone Feb 19, 2022

Uh oh!

Uh oh!

Conversation

ivanloz commented Dec 8, 2021

Usage

Comments/Caveats

TODO

Uh oh!

rust-highfive commented Dec 8, 2021

Uh oh!

rust-highfive commented Dec 8, 2021

Uh oh!

This comment has been minimized.

Uh oh!

ivanloz commented Dec 9, 2021

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

davidtwco commented Dec 13, 2021

Uh oh!

tmiasko commented Dec 13, 2021

Uh oh!

ivanloz commented Dec 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JohnCSimon commented Jan 23, 2022

Uh oh!

ivanloz commented Jan 24, 2022

Uh oh!

Uh oh!

Uh oh!

nagisa commented Feb 11, 2022

Uh oh!

bors commented Feb 13, 2022

Uh oh!

ivanloz commented Feb 15, 2022

Uh oh!

nagisa commented Feb 15, 2022

Uh oh!

bors commented Feb 15, 2022

Uh oh!

bors commented Feb 16, 2022

Uh oh!

bors commented Feb 16, 2022

Uh oh!

This comment has been minimized.

ivanloz commented Feb 16, 2022

Uh oh!

nagisa commented Feb 16, 2022

Uh oh!

bors commented Feb 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants