Uh oh!
There was an error while loading. Please reload this page.
Use a const ParamEnv when in default_method_body_is_const - #92037
Merged
Conversation
oli-obk
commented
Dec 17, 2021
Contributor
@bors r+ rollup |
bors
commented
Dec 17, 2021
Collaborator
📌 Commit a1f91aa has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91566 (Apply path remapping to DW_AT_GNU_dwo_name when producing split DWARF) - rust-lang#91926 (Remove `in_band_lifetimes` from `rustc_metadata`) - rust-lang#91931 (Remove `in_band_lifetimes` from `rustc_codegen_llvm`) - rust-lang#92024 (rustc_codegen_llvm: Give each codegen unit a unique DWARF name on all platforms, not just Apple ones.) - rust-lang#92037 (Use a const ParamEnv when in default_method_body_is_const) - rust-lang#92047 (Set `RUST_BACKTRACE=0` when running location-detail tests) - rust-lang#92050 (Add a space and 2 grave accents ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
This PR fixes the param_env function to return
constness: Constcorrectly for trait methods marked with#[default_method_body_is_const]. The snippet below is erroneously accepted by the compiler and has been fixed by this change. (Playground)