Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #92064
Merged
Merged
Conversation
See rust-lang#91867 for more information.
See rust-lang#91867 for more information.
The lifetime name shoud always appear in text surrounded by `.
DF_ORIGIN flag signifies that the object being loaded may make reference to the $ORIGIN substitution string. Some implementations are just ignoring DF_ORIGIN and do substitution for $ORIGIN if present (whatever DF_ORIGIN pr Set the flag inconditionally if rpath is wanted.
Use a separate nameless `DefPathData` variant instead
pass -Wl,-z,origin to set DF_ORIGIN when using rpath DF_ORIGIN flag signifies that the object being loaded may make reference to the $ORIGIN substitution string. Some implementations are just ignoring [DF_ORIGIN](http://www.sco.com/developers/gabi/latest/ch5.dynamic.html#df_flags) and do [substitution](http://www.sco.com/developers/gabi/latest/ch5.dynamic.html#substitution) for $ORIGIN if present (whatever DF_ORIGIN presence or not) like glibc. But some others mandate the present of DF_ORIGIN for the substitution (like OpenBSD). Set the flag inconditionally if rpath is wanted. One possible fallout is if the linker rejects `-z origin` option.
…mpl, r=michaelwoerister Remove `in_band_lifetimes` from `rustc_query_impl` See rust-lang#91867 for more information.
…, r=nagisa Remove `in_band_lifetimes` from `rustc_privacy` See rust-lang#91867 for more information.
…=jsha Clean up search code and unify function returned values This PR is a cleanup: there is no changes in the search results or in the UI. Depending if it was "literal search" or not, it was either returning booleans or integers. It's pretty bad so instead it all returns integers. Another thing I did was to move the add and checks into a `addIntoResults` function to simplify things. Last thing: I removed a loop in the `sortResults` function and moved its code directly into the first loop. All these changes are done to make rust-lang#90630 much smaller. r? `@jsha`
Fix typo in "new region bound" suggestion The lifetime name shoud always appear in text surrounded by `.
…ebank Eliminate duplicate codes of expected_found_bool The function expected_found_bool is the same as ExpectedFound::new. So use ExpectedFound::new to replace expected_found_bool to eliminate duplicate codes. 
hir: Do not introduce dummy type names for `extern` blocks in def paths Use a separate nameless `DefPathData` variant instead. Extracted from rust-lang#91795.
matthiaskrgr
commented
Dec 18, 2021
MemberAuthor
@bors r+ rollup=never p=7 |
bors
commented
Dec 18, 2021
Collaborator
📌 Commit 5e8f934 has been approved by |
bors
commented
Dec 18, 2021
Collaborator
⌛ Testing commit 5e8f934 with merge 52af1541831a590faf87df6a229a453fb07fdf01... |
rust-log-analyzer
commented
Dec 18, 2021
Collaborator
bors
commented
Dec 18, 2021
Collaborator
💔 Test failed - checks-actions |
GuillaumeGomez
commented
Dec 18, 2021
Member
@bors retry |
bors
commented
Dec 18, 2021
Collaborator
bors
commented
Dec 18, 2021
Collaborator
☀️ Test successful - checks-actions |
This was referenced Dec 18, 2021
rust-timer
commented
Dec 18, 2021
Collaborator
Finished benchmarking commit (d3848cb): comparison url. Summary: This change led to large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
in_band_lifetimesfromrustc_query_impl#91923 (Removein_band_lifetimesfromrustc_query_impl)in_band_lifetimesfromrustc_privacy#91925 (Removein_band_lifetimesfromrustc_privacy)externblocks in def paths #92032 (hir: Do not introduce dummy type names forexternblocks in def paths)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup