Uh oh!
There was an error while loading. Please reload this page.
Don't emit shared files when scraping examples from dependencies in Rustdoc - #92146
Merged
Conversation
jyn514
commented
Dec 21, 2021
Member
This seems kind of hacky ... eventually I'd like to separate actually generating the HTML from creating the Context. But this is reasonable as a short term fix. r=me if you don't feel like refactoring half of rustdoc 😁 @bors delegate=willcrichton |
bors
commented
Dec 21, 2021
Collaborator
✌️ @willcrichton can now approve this pull request |
willcrichton
commented
Dec 21, 2021
ContributorAuthor
@bors r=jyn514 |
bors
commented
Dec 21, 2021
Collaborator
📌 Commit b7de797 has been approved by |
bors
commented
Dec 21, 2021
Collaborator
⌛ Testing commit b7de797 with merge 695c53cca37057a9e61db16840932e68adf7acf6... |
rust-log-analyzer
commented
Dec 22, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Dec 22, 2021
Collaborator
💔 Test failed - checks-actions |
ehuss
commented
Dec 22, 2021
Contributor
@bors retry Windows test_interior_nul issue |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#88858 (Allow reverse iteration of lowercase'd/uppercase'd chars) - rust-lang#91544 (Fix duplicate derive clone suggestion) - rust-lang#92026 (Add some JSDoc comments to rustdoc JS) - rust-lang#92117 (kmc-solid: Add `std::sys::solid::fs::File::read_buf`) - rust-lang#92139 (Change Backtrace::enabled atomic from SeqCst to Relaxed) - rust-lang#92146 (Don't emit shared files when scraping examples from dependencies in Rustdoc) - rust-lang#92208 (Quote bat script command line) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes#91605. The issue is that
Context::initgets called when scraping dependencies. By default, just callinginitcalls intowrite_sharedandbuild_indexwhich register the scraped crate into a list that later gets used for the Rustdoc sidebar. The fix is to ensure thatwrite_sharedis not called when scraping.r? @jyn514