rustc_metadata: Merge get_ctor_def_id and get_ctor_kind

[petrochenkov]

Also avoid decoding the whole ty::AssocItem to get a has_self flag.

A small optimization and cleanup extracted from #89059.

[rust-highfive]

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

[petrochenkov]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit bff171e4413836415fec047722c65fdef683fa81 with merge 27aa2e969cf95a597a53c308076e6afc1960652a...

[bors]

☀️ Try build successful - checks-actions
Build commit: 27aa2e969cf95a597a53c308076e6afc1960652a (27aa2e969cf95a597a53c308076e6afc1960652a)

[rust-timer]

Queued 27aa2e969cf95a597a53c308076e6afc1960652a with parent 87e8639, future comparison URL.

[rust-timer]

Finished benchmarking commit (27aa2e969cf95a597a53c308076e6afc1960652a): comparison url.

Summary: This change led to moderate relevant regressions 😿 in compiler performance.

• Moderate regression in instruction counts (up to 4.9% on incr-patched: println builds of regression-31157)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[petrochenkov]

cc rust-lang/rustc-perf#1126

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 337ced2 with merge 376ed6d45e21820135727ec862ea00f16a87f56b...

[bors]

☀️ Try build successful - checks-actions
Build commit: 376ed6d45e21820135727ec862ea00f16a87f56b (376ed6d45e21820135727ec862ea00f16a87f56b)

[rust-timer]

Queued 376ed6d45e21820135727ec862ea00f16a87f56b with parent e100ec5, future comparison URL.

[rust-timer]

Finished benchmarking commit (376ed6d45e21820135727ec862ea00f16a87f56b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[davidtwco]

@bors r+

[bors]

📌 Commit 337ced2 has been approved by davidtwco

[bors]

⌛ Testing commit 337ced2 with merge aad4f10...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing aad4f10 to master...

[rust-timer]

Finished benchmarking commit (aad4f10): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression