Skip to content

resolve: Minor miscellaneous cleanups from #89059 - #92161

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:misclean
Dec 28, 2021
Merged

resolve: Minor miscellaneous cleanups from #89059#92161
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:misclean

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

@bors rollup=always

@rust-highfive

rust-highfive commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 21, 2021
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2021
@petrochenkovpetrochenkov mentioned this pull request Dec 21, 2021
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot

cjgillot commented Dec 26, 2021

Copy link
Copy Markdown
Contributor

r? @cjgillot
@bors r+

@bors

bors commented Dec 26, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 1324100 has been approved by cjgillot

@rust-highfiverust-highfive assigned cjgillot and unassigned nagisaDec 26, 2021
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2021
@bors

bors commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1324100 with merge 75708f7f10f343f68edf35d4fa3d7347f64c4672...

@rust-log-analyzer

rust-log-analyzer commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-cargo failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
fatal: Could not parse object '91493fe47175076f330ce5fc518f0196c0476f56'.
error: RPC failed; curl 56 OpenSSL SSL_read: Connection was reset, errno 10054
error: 15 bytes of body are still expected
fatal: expected flush after ref listing
thread 'main' panicked at 'assertion failed: status.success()', src\tools\cargotest\main.rs:125:13
command did not execute successfully: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools-bin\\cargotest.exe" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools-bin\\cargo.exe" "D:\\a\\rust\\rust\\build\\ct"
expected success, got: exit code: 101

@bors

bors commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021
@petrochenkov

petrochenkov commented Dec 27, 2021

Copy link
Copy Markdown
ContributorAuthor

@bors r=cjgillot rollup

@bors

bors commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Add Attribute::meta_kind #92294

@bors

bors commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 1324100 has been approved by cjgillot

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021
@bors

bors commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1324100 with merge ef6f773c97230531e0178453528bee9f05ce5f83...

@bors

bors commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021
@lnicola

lnicola commented Dec 27, 2021

Copy link
Copy Markdown
Member

@bors retry

GitHub had a bad day.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021
@rust-log-analyzer

rust-log-analyzer commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2021
@bors
Auto merge ofrust-lang#92329- matthiaskrgr:rollup-l3b4fl1, r=matthi…
4ee34f3
…askrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#90586 (Relax priv-in-pub lint on generic bounds and where clauses of trait impls.)
- rust-lang#92112 (Fix the error of checking `base_expr` twice in type_changing_struct_update)
- rust-lang#92147 (rustc_builtin_macros: make asm mod public for rustfmt)
- rust-lang#92161 (resolve: Minor miscellaneous cleanups from rust-lang#89059)
- rust-lang#92264 (Remove `maybe_uninit_extra` feature from Vec docs)
- rust-lang#92303 (Add test cases for issue rust-lang#26186)
- rust-lang#92307 (Fix minor typos)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a11414d into rust-lang:masterDec 28, 2021
@rustbotrustbot added this to the 1.59.0 milestone Dec 28, 2021
@petrochenkov
petrochenkov deleted the misclean branch February 22, 2025 18:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cjgillotcjgillot

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

8 participants

@petrochenkov@rust-highfive@rust-log-analyzer@cjgillot@bors@lnicola@nagisa@rustbot