Uh oh!
There was an error while loading. Please reload this page.
[WIP] Misc incr comp improvements around span hashing invalidation - #92204
[WIP] Misc incr comp improvements around span hashing invalidation#92204Aaron1011 wants to merge 6 commits into
Conversation
This causes us to miss legitimate evaluatiosn (e.g. an upstream `ExpnId` no longer exists), leading to ICEs when decoding stale values from the incremental cache.
rust-highfive
commented
Dec 22, 2021
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
commented
Dec 22, 2021
(rust-highfive has picked a reviewer for you, use r? to override) |
Aaron1011
commented
Dec 22, 2021
@bors try @rust-timer queue |
rust-timer
commented
Dec 22, 2021
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
bors
commented
Dec 22, 2021
⌛ Trying commit eef9f4c with merge 6ab07dabd4dd50e695e1a20f09fb4efb077af4d9... |
rust-log-analyzer
commented
Dec 22, 2021
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Dec 22, 2021
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Dec 22, 2021
The job Click to see the possible cause of the failure (guessed by this bot) |
Aaron1011
commented
Dec 22, 2021
It looks like some of the newly-hashed spans are leaking into the |
Span field when hashing some Identsbors
commented
Jan 9, 2022
☔ The latest upstream changes (presumably #92534) made this pull request unmergeable. Please resolve the merge conflicts. |
Aaron1011
commented
Feb 14, 2022
#91921 was fixed by a different PR, so this PR is no longer needed. |
Fixes#91921
Fixes#92192
As expected, this causes a lot of new incremental invalidations. This PR currently contains some experiments to reduce the number of invalidations we run into in practice.