Skip to content

Move contains method of Option and Result lower in docs - #92530

Merged
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:contains
Jan 5, 2022
Merged

Move contains method of Option and Result lower in docs#92530
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:contains

Conversation

@dtolnay

Copy link
Copy Markdown
Member

Follow-up to #92444 trying to get the Option and Result rustdocs in better shape.

This addresses the request in #62358 (comment). The contains methods are previously too high up in the docs on both Option and Result — stuff like ok and map and and_then should all be featured higher than contains. All of those are more ubiquitously useful than contains.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2022
@the8472

Copy link
Copy Markdown
Member

It seems kind of suboptimal that we have to move so much code around (which breaks git history) just to reorganize docs.

@camelidcamelid added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api [DEPRECATED; DO NOT USE] T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api [DEPRECATED; DO NOT USE] labels Jan 4, 2022
@yaahc

yaahc commented Jan 4, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 4, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 7dec41a has been approved by yaahc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2022
@dtolnay

Copy link
Copy Markdown
MemberAuthor

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2022
…askrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#91587 (core::ops::unsize: improve docs for DispatchFromDyn)
- rust-lang#91907 (Allow `_` as the length of array types and repeat expressions)
- rust-lang#92515 (RustWrapper: adapt for an LLVM API change)
- rust-lang#92516 (Do not use deprecated -Zsymbol-mangling-version in bootstrap)
- rust-lang#92530 (Move `contains` method of Option and Result lower in docs)
- rust-lang#92546 (Update books)
- rust-lang#92551 (rename StackPopClean::None to Root)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit af49d81 into rust-lang:masterJan 5, 2022
@rustbotrustbot added this to the 1.59.0 milestone Jan 5, 2022
@dtolnay
dtolnay deleted the contains branch January 31, 2022 08:03
@dtolnaydtolnay removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsT-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dtolnay@rust-highfive@the8472@yaahc@bors@camelid@rustbot