Skip to content

Implement RFC 3151: Scoped threads. - #92555

Merged
bors merged 18 commits into
rust-lang:masterfrom
m-ou-se:scoped-threads
Jan 24, 2022
Merged

Implement RFC 3151: Scoped threads.#92555
bors merged 18 commits into
rust-lang:masterfrom
m-ou-se:scoped-threads

Conversation

@m-ou-se

@m-ou-sem-ou-se commented Jan 4, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This implements rust-lang/rfcs#3151

Tracking issue: #93203

r? @Amanieu

@m-ou-se
Simpilfy thread::JoinInner.
a45b3ac
@m-ou-se
Implement RFC 3151: Scoped threads.
0e24ad5
@m-ou-se
Add ScopedJoinHandle::is_running().
cc699e1
@m-ou-se
Add documentation for scoped threads.
da33da1
@m-ou-se
Simplify panicking mechanism of thread::scope.
f521779
It now panic!()s on its own, rather than resume_unwind'ing the panic
payload from the thread. Using resume_unwind skips the panic_handler,
meaning that the main thread would never have a panic handler run, which
can get confusing.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2022
@m-ou-sem-ou-se mentioned this pull request Jan 4, 2022
Merged
@m-ou-sem-ou-se added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api [DEPRECATED; DO NOT USE] A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows labels Jan 4, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
programmerjake
programmerjake reviewed Jan 4, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs Outdated
MattiasBuelens
MattiasBuelens reviewed Jan 4, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs Outdated
@m-ou-se@MattiasBuelens
Fix typo in is_running() docs.
c429ade
Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
zesterer
zesterer reviewed Jan 4, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs
deltragon
deltragon reviewed Jan 4, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs Outdated
@m-ou-se@deltragon
Fix typo in Scope::spawn docs.
5b5746f
Co-authored-by: deltragon <m@dafert.at>
danielhenrymantilla
danielhenrymantilla reviewed Jan 4, 2022
View reviewed changes

@danielhenrymantilladanielhenrymantilla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty slick!

Comment threadlibrary/std/src/thread/mod.rs
Comment threadlibrary/std/src/thread/scoped.rs
Comment threadlibrary/std/src/thread/scoped.rs Outdated
Comment threadlibrary/std/src/thread/mod.rs
Comment threadlibrary/std/src/thread/mod.rs Outdated
Comment threadlibrary/std/src/thread/scoped.rs
danielhenrymantilla
danielhenrymantilla reviewed Jan 4, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs
Amanieu
Amanieu reviewed Jan 5, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs Outdated
Comment threadlibrary/std/src/thread/scoped.rs Outdated
Comment threadlibrary/std/src/thread/scoped.rs Outdated
Comment threadlibrary/std/src/thread/scoped.rs Outdated
frewsxcv
frewsxcv reviewed Jan 5, 2022
View reviewed changes
Comment threadlibrary/std/src/thread/scoped.rs
Comment threadlibrary/std/src/thread/scoped.rs
@m-ou-se@Amanieu
Mention *scoped* thread in panic message.
4cb7370
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
@m-ou-sem-ou-se mentioned this pull request Jan 22, 2022
Closed
10 tasks
@m-ou-sem-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2022
@m-ou-se

m-ou-se commented Jan 22, 2022

Copy link
Copy Markdown
MemberAuthor

@Amanieu I've added the tracking issue number, so this is now ready for review/merging.

@Amanieu

Amanieu commented Jan 23, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 465c405 has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2022
@bors
Auto merge ofrust-lang#93245- matthiaskrgr:rollup-djsi6jr, r=matthi…
42313dd
…askrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#91526 (rustc_lint: Some early linting refactorings)
- rust-lang#92555 (Implement RFC 3151: Scoped threads.)
- rust-lang#93213 (Fix `let_chains` and `if_let_guard` feature flags)
- rust-lang#93219 (Add preliminary support for inline assembly for msp430.)
- rust-lang#93226 (Normalize field access types during borrowck)
- rust-lang#93227 (Liberate late bound regions when collecting GAT substs in wfcheck)
- rust-lang#93229 (Remove DiagnosticBuilder.quiet)
- rust-lang#93234 (rustc_mir_itertools: Avoid needless `collect` with itertools)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bb260e8 into rust-lang:masterJan 24, 2022
@rustbotrustbot added this to the 1.60.0 milestone Jan 24, 2022
@m-ou-se
m-ou-se deleted the scoped-threads branch January 24, 2022 06:42
@gregbuchholzgregbuchholz mentioned this pull request Feb 5, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments
@programmerjakeprogrammerjakeprogrammerjake left review comments
+6 more reviewers
@frewsxcvfrewsxcvfrewsxcv left review comments
@MattiasBuelensMattiasBuelensMattiasBuelens left review comments
@zestererzestererzesterer left review comments
@chorman0773chorman0773chorman0773 left review comments
@danielhenrymantilladanielhenrymantilladanielhenrymantilla left review comments
@deltragondeltragondeltragon left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@AmanieuAmanieu

Labels

A-runtimeArea: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflowsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.60.0

Development

Successfully merging this pull request may close these issues.

13 participants

@m-ou-se@rust-log-analyzer@Amanieu@bors@frewsxcv@MattiasBuelens@zesterer@programmerjake@chorman0773@danielhenrymantilla@deltragon@rust-highfive@rustbot