Skip to content

Rollup of 7 pull requests - #92593

Closed
matthiaskrgr wants to merge 21 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-5jb5lc6
Closed

Rollup of 7 pull requests#92593
matthiaskrgr wants to merge 21 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-5jb5lc6

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jackh726and others added 21 commits December 24, 2021 14:35
Also update Node to v16.9.0, es-check to 6.1.1, and eslint to 8.6.0.
This reduces clutter on doc pages.
A missing break statement lead to an infinite loop in bootstrap.py.
…dtwco
Some cleanups around check_argument_types
Split out in ways from my rebase/continuation of rust-lang#71827
Commits are mostly self-explanatory and these changes should be fairly straightforward
…crum
Regression test for borrowck ICE rust-lang#92015
This issue has come up a few times. Creating a regression test.
Closesrust-lang#92015.
…imitive-types, r=Manishearth
Rustdoc: resolve associated traits for non-generic primitive types
Fixesrust-lang#90703
This seems to work:
<img width="457" alt="image" src="https://user-images.githubusercontent.com/2807772/147774059-9556ff96-4519-409e-8ed0-c33ecc436171.png">
I'm just afraid I might have missed some cases / broken previous functionality.
I also have not written tests yet, I will have to take a look to see where tests are and how they are structured, but any help there is also appreciated.
…Gomez
Move crate drop-down to search results page
This reduces clutter on doc pages.
Part of rust-lang#59840
r? `@GuillaumeGomez`
Demo: https://rustdoc.crud.net/jsha/crates-in-results/std/index.html?search=str
Allow unwinding from OOM hooks
This is split off from rust-lang#88098 and contains just the bare minimum to allow specifying a custom OOM hook with `set_alloc_error_hook` which unwinds instead of aborting.
See rust-lang#88098 for an actual command-line flag which switches the default OOM behavior to unwind instead of aborting.
Previous perf results show a negligible impact on performance.
…ant-count, r=the8472
Add note about non_exhaustive to variant_count
Since `variant_count` isn't returning something opaque, I thought it makes sense to explicitly call out that its return value may change for some enums.
cc rust-lang#73662
…lacrum
Break the loop
A missing break statement lead to an infinite loop in bootstrap.py.
I also added a short sleep so it's not constantly running at 100%. But I can remove that if it's not wanted.
Fixesrust-lang#76661
@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 5, 2022
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=7

@bors

bors commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit cc59087 has been approved by matthiaskrgr

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 5, 2022
@mati865

Copy link
Copy Markdown
Member

FYI #92589 has been r-

@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

It was just r+ed again.. ^^

@bors

bors commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cc59087 with merge 4cf8b4fb1dd5428878ddb340f2b8328f8cc425bd...

@bors

bors commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2022
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2022
@bors

bors commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cc59087 with merge 05b8f377b6258b78c5136bb362fdd60fecfb74c5...

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2022
@hkratzhkratz mentioned this pull request Jan 11, 2022
@matthiaskrgr
matthiaskrgr deleted the rollup-5jb5lc6 branch February 13, 2022 00:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@mati865@rust-log-analyzer@rustbot@jackh726@chordtoll@Amanieu@Mark-Simulacrum@mdibaiee@jsha@ChrisDenton